740976 - [tinder] waterfall table lacks borders

Status: RESOLVED FIXED

(Webtools Graveyard :: Elmo, defect)

Description

[Axel Hecht [:Pike]]

The waterfall table wants borders, and says so by border='1', but the reset rules seem to win over that.

Let's have borders back, class="border"?

class="standard" doesn't read a lot better right now due to the lack of vertical borders. Also, a solid black border is better to navigate in this view than same fainter signal, IMHO.

Comment 1

[Peter Bengtsson [:peterbe]]

Attachment: A border on the td cells with color #99999

I also fixed the HTML a bit so it validates. 
Current look: http://cl.ly/0R1N2W2y3j3N3q2v0F3c

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 611053 [details] [diff] [review]
A border on the td cells with color #99999

Review of attachment 611053 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with the color nit below.

::: apps/tinder/static/tinder/css/waterfall.css
@@ +45,4 @@
>  td.step {min-height: 1em;}
>  td.white {vertical-align: bottom;}
>  table#water {empty-cells: show; }
> +table#water td {border: 1px solid #999;}

Make that #666 instead?

999 is OK between orange and white, but in a block of green builds, it's not enough contrast yet.

Comment 3

[Peter Bengtsson [:peterbe]]

https://github.com/mozilla/elmo/commit/bb1173c70059a7180fb7cd6ec35ada025d5f7798