741024 - nsDOMFileReader could use nsContentUtils for stream conversion

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Jan Varga [:janv]]

I'm implementing readAsText() for FileHandle and I found out that we could remove some code in FileReader and just call nsContentUtils::ConvertStringFromCharset() and nsContentUtils::CheckForBOM()

Comment 1

[Jan Varga [:janv]]

Also, FileReaderSyncPrivate::GuessCharset() seems to support UTF-32 when checking for BOM. We don't support it in nsDOMFileReader() nor in nsContentUtils::CheckForBOM()

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Jan Varga [:janv] from comment #1)
> Also, FileReaderSyncPrivate::GuessCharset() seems to support UTF-32 when
> checking for BOM. We don't support it in nsDOMFileReader() nor in
> nsContentUtils::CheckForBOM()

We shouldn't, I don't think.

Comment 3

[Jan Varga [:janv]]

ok, but why ?

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.