Closed Bug 741051 Opened 12 years ago Closed 11 years ago

Tracking bug of PDF broken bugs in Github

Categories

(Firefox :: PDF Viewer, defect)

defect
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox15 - ---
firefox16 - ---

People

(Reporter: scoobidiver, Unassigned)

References

()

Details

(Whiteboard: [pdfjs-c-other])

Before landing PDF Viewer in a release version, all PDF-broken bugs should be fixed in order to have a one-to-one rendering matching with any PDF reader plugin.
Hello Scoobidiver, 

The pdf-broken bugs on Github are a very, very small sample of PDFs that we currently don't support. Fixing them would not by any means give us a one-to-one matching with PDF readers that have been around for years or decades (we're barely a year old).

That being said, we have explored a metric along the lines of "we currently correctly display about XX% of PDFs sampled from the wild", but it's very difficult to come up with an automated system that can tell us if our output is "close enough" to a given reference image from a more mature renderer (due to all sorts of nuances with implementations and backends).

Perhaps an alternative (if this type of thing is at all possible) is to keep PDF.js in Nightly/Aurora for a while, say several months, and rely on the subjective opinion of our users to decide if we're ready for prime time. Perhaps keep it there until most folks are happy with our rendering accuracy? (Just brainstorming at this point :)).
It would be great to see those bugs tracked here instead of in Github so that we have the data (bugs) needed for tracking regressions and progress on this.
Asa - please re-nominate for FF16 if you believe this metric should be a blocker for release.
We're tracking all FF blockers in this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=748923

Closing it, please reopen if deemed inappropriate - thanks!
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [pdfjs-other]
(In reply to Artur Adib from comment #4)
> Closing it, please reopen if deemed inappropriate - thanks!
There are still 129 github bugs about PDF broken.
Blocks: 748923
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [pdfjs-other] → [pdfjs-c-other]
This is somewhat of an unrealistic expectation, not even Acrobat supports all the various broken/corrupted pdfs out there.  As Artur has said we're tracking release blockers in bug 748923.
129 bugs is indeed a lot, but many ones can be closed as a dupe of another bug and you can add a parity-adobe label for those that really need to be fixed.
(In reply to Scoobidiver from comment #7)
> but many ones can be closed as a dupe of another bug 

in the past, even if bugs have the similar signature they might not be fixed by the same patch.

> and you can add a parity-adobe label for those that really need to be fixed.

That would be a subjective opinion if it's need to be fixed asap -- some of the pdfs might contain corrupted fonts and invalid pdf structure. Also some of the pdf might not render properly in the reader, but it renders okay in the preview.
I'm removing this as a blocker for bug 748923.  We would love to fix all the bugs on github before release but it we need to release at some point and incrementally improve.
No longer blocks: 748923
Per comment #9 closing as won't fix
Status: REOPENED → RESOLVED
Closed: 12 years ago11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.