"function ... does not always return a value" in browserPlacesViews.js, controller.js and treeView.js

VERIFIED FIXED in seamonkey2.11

Status

SeaMonkey
Bookmarks & History
P3
normal
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.11
Dependency tree / graph
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.9 fixed, seamonkey2.10 fixed)

Details

Attachments

(3 attachments)

(Assignee)

Description

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333157656.1333161682.31203.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/03/30 18:34:16
{
JavaScript strict warning: chrome://communicator/content/places/browserPlacesViews.js, line 117: anonymous function does not always return a value

JavaScript strict warning: chrome://communicator/content/places/browserPlacesViews.js, line 1563: function PT__onPopupShowing does not always return a value

JavaScript strict warning: chrome://communicator/content/places/controller.js, line 1497: function PCDH_onDrop does not always return a value

JavaScript strict warning: chrome://communicator/content/places/treeView.js, line 302: function PTV__buildVisibleSection does not always return a value

JavaScript strict warning: chrome://communicator/content/places/treeView.js, line 344: function PTV__buildVisibleSection does not always return a value
}
(Assignee)

Updated

6 years ago
Depends on: 741064
(Assignee)

Updated

6 years ago
Depends on: 741065
(Assignee)

Updated

6 years ago
Depends on: 741066
(Assignee)

Comment 1

6 years ago
Created attachment 611286 [details] [diff] [review]
(Av1) Port |Bug 741064 - treeView.js: "function PTV__buildVisibleSection does not always return a value"| to SeaMonkey
[Checked in: Comment 4 & 9 & 8]
Attachment #611286 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 2

6 years ago
Created attachment 611831 [details] [diff] [review]
(Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey
[Checked in: Comment 5 & 9 & 8]
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #611831 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 3

6 years ago
Created attachment 611835 [details] [diff] [review]
(Cv1) Port |Bug 741066 - browserPlacesViews.js: 2 "function ... does not always return a value"| to SeaMonkey
[Checked in: Comment 6 & 9 & 8]
Attachment #611835 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

6 years ago
Attachment #611286 - Flags: review?(neil)
(Assignee)

Updated

6 years ago
Attachment #611831 - Flags: review?(neil)
(Assignee)

Updated

6 years ago
Attachment #611835 - Flags: review?(neil)

Updated

6 years ago
Attachment #611286 - Flags: review?(neil) → review+

Updated

6 years ago
Attachment #611831 - Flags: review?(neil) → review+

Updated

6 years ago
Attachment #611835 - Flags: review?(neil) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 611286 [details] [diff] [review]
(Av1) Port |Bug 741064 - treeView.js: "function PTV__buildVisibleSection does not always return a value"| to SeaMonkey
[Checked in: Comment 4 & 9 & 8]

http://hg.mozilla.org/comm-central/rev/e36a8742ed06
Attachment #611286 - Attachment description: (Av1) Port |Bug 741064 - treeView.js: "function PTV__buildVisibleSection does not always return a value"| to SeaMonkey → (Av1) Port |Bug 741064 - treeView.js: "function PTV__buildVisibleSection does not always return a value"| to SeaMonkey [Checked in: Comment 4]
Attachment #611286 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 5

6 years ago
Comment on attachment 611831 [details] [diff] [review]
(Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey
[Checked in: Comment 5 & 9 & 8]

http://hg.mozilla.org/comm-central/rev/ea708dd6ae27
Attachment #611831 - Attachment description: (Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey → (Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey [Checked in: Comment 5]
Attachment #611831 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 6

6 years ago
Comment on attachment 611835 [details] [diff] [review]
(Cv1) Port |Bug 741066 - browserPlacesViews.js: 2 "function ... does not always return a value"| to SeaMonkey
[Checked in: Comment 6 & 9 & 8]

http://hg.mozilla.org/comm-central/rev/9998f4b43479
Attachment #611835 - Attachment description: (Cv1) Port |Bug 741066 - browserPlacesViews.js: 2 "function ... does not always return a value"| to SeaMonkey → (Cv1) Port |Bug 741066 - browserPlacesViews.js: 2 "function ... does not always return a value"| to SeaMonkey [Checked in: Comment 6]
Attachment #611835 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
(Assignee)

Comment 7

6 years ago
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1333905792.1333909794.26368.gz&fulltext=1
WINNT 5.2 comm-central-trunk debug test mochitests-3/5 on 2012/04/08 10:23:12

V.Fixed
Status: RESOLVED → VERIFIED
(Assignee)

Updated

6 years ago
Attachment #611286 - Flags: approval-comm-beta?
Attachment #611286 - Flags: approval-comm-aurora?
(Assignee)

Updated

6 years ago
Attachment #611831 - Flags: approval-comm-beta?
Attachment #611831 - Flags: approval-comm-aurora?
(Assignee)

Updated

6 years ago
Attachment #611835 - Flags: approval-comm-beta?
Attachment #611835 - Flags: approval-comm-aurora?

Updated

6 years ago
Attachment #611286 - Flags: approval-comm-beta?
Attachment #611286 - Flags: approval-comm-beta+
Attachment #611286 - Flags: approval-comm-aurora?
Attachment #611286 - Flags: approval-comm-aurora+

Updated

6 years ago
Attachment #611831 - Flags: approval-comm-beta?
Attachment #611831 - Flags: approval-comm-beta+
Attachment #611831 - Flags: approval-comm-aurora?
Attachment #611831 - Flags: approval-comm-aurora+

Updated

6 years ago
Attachment #611835 - Flags: approval-comm-beta?
Attachment #611835 - Flags: approval-comm-beta+
Attachment #611835 - Flags: approval-comm-aurora?
Attachment #611835 - Flags: approval-comm-aurora+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Whiteboard: [c-n: e36a8742ed06, ea708dd6ae27 and 9998f4b43479 to c-a and c-b]
http://hg.mozilla.org/releases/comm-beta/rev/5389cca69224
http://hg.mozilla.org/releases/comm-beta/rev/653d3b0d33ae
http://hg.mozilla.org/releases/comm-beta/rev/e062cb10015c

(odd that multi-import from qimportbz took them in backwards order, but they all applied fine anyway)
status-seamonkey2.9: --- → fixed
Whiteboard: [c-n: e36a8742ed06, ea708dd6ae27 and 9998f4b43479 to c-a and c-b] → [c-n: e36a8742ed06, ea708dd6ae27 and 9998f4b43479 to c-a]

Updated

6 years ago
status-seamonkey2.10: --- → fixed
(Assignee)

Updated

6 years ago
Attachment #611835 - Attachment description: (Cv1) Port |Bug 741066 - browserPlacesViews.js: 2 "function ... does not always return a value"| to SeaMonkey [Checked in: Comment 6] → (Cv1) Port |Bug 741066 - browserPlacesViews.js: 2 "function ... does not always return a value"| to SeaMonkey [Checked in: Comment 6 & 9 & 8]
(Assignee)

Updated

6 years ago
Attachment #611831 - Attachment description: (Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey [Checked in: Comment 5] → (Bv1) Port |Bug 741065 - controller.js: "function PCDH_onDrop does not always return a value"| to SeaMonkey [Checked in: Comment 5 & 9 & 8]
(Assignee)

Updated

6 years ago
Attachment #611286 - Attachment description: (Av1) Port |Bug 741064 - treeView.js: "function PTV__buildVisibleSection does not always return a value"| to SeaMonkey [Checked in: Comment 4] → (Av1) Port |Bug 741064 - treeView.js: "function PTV__buildVisibleSection does not always return a value"| to SeaMonkey [Checked in: Comment 4 & 9 & 8]
(Assignee)

Comment 10

6 years ago
Ftr, this can't be verified on SM 2.10/2.9 as the warning were not reported there.
You need to log in before you can comment on or make changes to this bug.