741108 - Change background color for selected item in the reminder dialog in Windows 7 High Contrast mode (unreadable green on grey)

Status: RESOLVED FIXED

(Calendar :: OS Integration, defect)

Description

[Matthew Toseland]

User Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120315 Iceweasel/3.5.16 (like Firefox/3.5.16)
Build ID: 20120315090431

Steps to reproduce:

Set Windows 7 to High Contrast theme (forces green on black in most apps). Set up a reminder in Lightning. Wait until the reminder dialog shows up.


Actual results:

Reminder dialog shows the selected item in green (from Windows) on light grey. This is not readable.


Expected results:

Like in #671119, Lightning should detect that Windows is using the High Contrast theme and change the background color (e.g. to the default from the windows theme, which here is black).

The individual can fix this via a userContent.css hack, but it should work out of the box for maximum accessibility.

The relevant theme CSS is here, but I was not easily able to find a theme which changes this:
http://mxr.mozilla.org/comm-central/source/calendar/base/themes/common/dialogs/calendar-alarm-dialog.css

The eventual solution locally was to put this in userChrome.css:
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");

calendar-alarm-widget[selected="true"] {
    background-color: #000000 !important;
    padding: 0 5px;
}

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Patch

I've copied the system colors from richlistitem to calendar-alarm-widget. This works good on all systems. Only the Details... link isn't well readable under Mac and Linux with default Ubuntu theme. I decided to give the link the same color as the other text. With the underline it is still discoverable as link.

I removed also mozapps/skin/extensions/itemEnabledFader.png because this exists no more.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Reminder screenshot

Screenshot showing the link color issue under Mac and Ubuntu default. With Adwaita (the reminder on bottom) theme this would be no problem.

Because of this problem I gave for the link the same color as for the other text.

Comment 3

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 611269 [details] [diff] [review]
Patch

r=philipp

Too bad on the details link, but I don't see many alternatives.

Comment 4

[Richard Marti (:Paenglab)]

Pushed to comm-central: <http://hg.mozilla.org/comm-central/rev/faf0d25b0c60>

Comment 5

[BJ]

Yes it might be. Sorry I didn't spot that when I searched.

There are 2 ways of going about it:

1 - take colour settings from the OS. This is what TB does (mostly). This allows the Windows HCB and any bespoke colour settings to work for the user who then gets the colours they want.

2 - Let Lightning set it's own colours. But it must set ALL colours which is what it fails to do. Ir sets some and takes others from the OS so we get these problems.

I have screen shots now to show that the white text on blue takes white from the OS but the blue background is set within Lightning.

Should I post these screen shots now?