741132 - Plugin doorhanger reappears after switching tabs after Flash has been enabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

You need to have the "Tap to Play" setting enabled for plugins for this bug.

See url testcase, steps to reproduce:
- Make sure you have at least 2 tabs open
- Visit testcase, the plugin doorhanger appears after 2 seconds, ignore it by tapping outside of it.
- Tap on the first 'Tap here to activate plugin' plugin placeholder
- Tap on the 'Tap here to activate plugin' placeholder plugin
- Switch to another tab
- Switch back to this tab

Expected result:
- No plugin doorhanger appears, because Flash is already enabled on the page.

Actual result:
- Plugin doorhanger appears.

Tested in today's trunk Fennec Native build on the Samsung Galaxy SII.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Need to call |NativeWindow.doorhanger.hide(...)| in playAllPlugins at https://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#3957

Comment 2

[:Margaret Leibovic]

Attachment: patch

Quick simple patch.

The call to playAllPlugins in the doorhanger button callback takes care of hiding the doorhanger for us, and this is the only other place we call playAllPlugins, so this is the only place we need to worry about hiding the doorhanger if it's been shown.

Comment 3

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9135a11eb1a2

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/9135a11eb1a2

Comment 5

[Martijn Wargers (dead)]

Verified fixed in today's trunk build (2012-04-14) on the Samsung Galaxy SII.