741245 - Remove nsresult return value from nsXPConnect::GetSafeJSContext()

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Comment 1

[Bobby Holley (:bholley)]

Comment on attachment 611320 [details] [diff] [review]
Patch v1


>diff --git a/toolkit/xre/nsXREDirProvider.cpp b/toolkit/xre/nsXREDirProvider.cpp


>-      if (stack)
>-      {
>-        JSContext *cx = nsnull;
>-        stack->GetSafeJSContext(&cx);
>-        if (cx)
>-          ::JS_GC(cx);
>+      if (stack) {
>+        if (JSContext* cx = stack->GetSafeJSContext()) {
>+          JS_GC(cx);
>+        }

Given the other style in this file, there should be no braces here.

Comment 2

[Masatoshi Kimura [:emk]]

Comment on attachment 611320 [details] [diff] [review]
Patch v1

> [uuid(b7056a2a-a02d-43b1-abb9-47f81f8bf258)]
> interface nsIThreadJSContextStack : nsIJSContextStack
> {
>     /* inherits methods of nsIJSContextStack */
>-    readonly attribute JSContext safeJSContext;
>+    [notxpcom,nostdcall] JSContext getSafeJSContext();
Please bump the iid.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4b0cc175806e