741287 - expandlibs_gen ignores missing files

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

This was revealed after landing bug 644608: expandlibs_gen happily works when some files are missing, and with bug 644608, dependencies are created for these missing files, and since they never exist, bug 644608 failed.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Make expandlibs_gen.py error out when given a missing file

Comment 2

[Mike Hommey [:glandium]]

Attachment: part 2 - Fix layout/build/Makefile.in for missing libraries

Comment 3

[(not currently active) Ted Mielczarek]

Comment on attachment 611372 [details] [diff] [review]
part 2 - Fix layout/build/Makefile.in for missing libraries

Review of attachment 611372 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/build/Makefile.in
@@ +149,5 @@
>  ifdef MOZ_B2G_RIL #{
> +SHARED_LIBRARY_LIBS	+= \
> +	$(DEPTH)/dom/system/gonk/$(LIB_PREFIX)domsystemgonk_s.$(LIB_SUFFIX) \
> +	$(DEPTH)/dom/telephony/$(LIB_PREFIX)domtelephony_s.$(LIB_SUFFIX) \
> +	$(NULL)

two-space indent, not tabs here, please.

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/748db85b1a01
https://hg.mozilla.org/integration/mozilla-inbound/rev/d405b4adf7f9

Comment 5

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/748db85b1a01
https://hg.mozilla.org/mozilla-central/rev/d405b4adf7f9