expandlibs_gen ignores missing files

RESOLVED FIXED in mozilla14

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

This was revealed after landing bug 644608: expandlibs_gen happily works when some files are missing, and with bug 644608, dependencies are created for these missing files, and since they never exist, bug 644608 failed.
Assignee: nobody → mh+mozilla
Created attachment 611371 [details] [diff] [review]
Make expandlibs_gen.py error out when given a missing file
Attachment #611371 - Flags: review?(ted.mielczarek)
Created attachment 611372 [details] [diff] [review]
part 2 - Fix layout/build/Makefile.in for missing libraries
Attachment #611372 - Flags: review?(ted.mielczarek)
Attachment #611371 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 611372 [details] [diff] [review]
part 2 - Fix layout/build/Makefile.in for missing libraries

Review of attachment 611372 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/build/Makefile.in
@@ +149,5 @@
>  ifdef MOZ_B2G_RIL #{
> +SHARED_LIBRARY_LIBS	+= \
> +	$(DEPTH)/dom/system/gonk/$(LIB_PREFIX)domsystemgonk_s.$(LIB_SUFFIX) \
> +	$(DEPTH)/dom/telephony/$(LIB_PREFIX)domtelephony_s.$(LIB_SUFFIX) \
> +	$(NULL)

two-space indent, not tabs here, please.
Attachment #611372 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/748db85b1a01
https://hg.mozilla.org/integration/mozilla-inbound/rev/d405b4adf7f9
https://hg.mozilla.org/mozilla-central/rev/748db85b1a01
https://hg.mozilla.org/mozilla-central/rev/d405b4adf7f9
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.