Last Comment Bug 741384 - Change MOZ_NOT_REACHED added in bug 732343 to MOZ_ASSERT(false)
: Change MOZ_NOT_REACHED added in bug 732343 to MOZ_ASSERT(false)
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: unspecified
: x86 Mac OS X
: -- normal (vote)
: mozilla14
Assigned To: Henri Sivonen (:hsivonen)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-02 06:46 PDT by Henri Sivonen (:hsivonen)
Modified: 2012-04-10 13:04 PDT (History)
2 users (show)
hsivonen: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Perform the substitution (3.85 KB, patch)
2012-04-03 01:57 PDT, Henri Sivonen (:hsivonen)
bugs: review+
Details | Diff | Review

Description Henri Sivonen (:hsivonen) 2012-04-02 06:46:21 PDT
Over in bug 732343 I thought to that MOZ_NOT_REACHED was syntactic sugar for MOZ_ASSERT(false).  That's not the case. Use the de-sugaring that I thought I was already using.
Comment 1 Henri Sivonen (:hsivonen) 2012-04-03 01:57:42 PDT
Created attachment 611744 [details] [diff] [review]
Perform the substitution
Comment 2 Henri Sivonen (:hsivonen) 2012-04-10 00:05:17 PDT
Thanks. Landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc8ce16a462d
Comment 3 :Ehsan Akhgari (busy, don't ask for review please) 2012-04-10 13:04:56 PDT
https://hg.mozilla.org/mozilla-central/rev/bc8ce16a462d

Note You need to log in before you can comment on or make changes to this bug.