741598 - enable finding elements of child nodes

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: Find child node support

Waited to land this after marionette landed on m-c. This patch changes parts of marionette-elements so it can handle searching for child elements of a given node.

Comment 1

[Jonathan Griffin (:jgriffin)]

Comment on attachment 611611 [details] [diff] [review]
Find child node support

Review of attachment 611611 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: testing/marionette/marionette-actors.js
@@ +270,5 @@
>     * @param boolean newSession
>     *        True if this is the first time we're talking to this browser
>     */
>    startBrowser: function MDA_startBrowser(win, newSession) {
>      let winId = this.addBrowser(win);

Looks like we can get rid of this variable assignment now, since 'winId' isn't used anywhere.

@@ +296,2 @@
>        //if there is a content listener, then we just wake it up
>        let winId = this.addBrowser(this.getCurrentWindow());

This variable assignment can go too.

Comment 2

[Malini Das [:mdas] - Away, not checking bugmail]

Attachment: Updated with assignment removal

Comment 3

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d0aa1570eb21

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/d0aa1570eb21

(http://blog.bonardo.net/2012/03/23/how-you-can-help-mozilla-inbound-sheriffs-when-pushing)