Closed
Bug 741620
Opened 14 years ago
Closed 14 years ago
Typos in the docs
Categories
(Add-on SDK Graveyard :: Documentation, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wbamberg, Assigned: wbamberg)
Details
Attachments
(1 file)
|
2.46 KB,
patch
|
dcm
:
review+
|
Details | Diff | Splinter Review |
There are at least two typos in the new SDK docs:
- one in "Listening for Load and Unload" reported by Paul Morris: http://groups.google.com/group/mozilla-labs-jetpack/browse_thread/thread/4f602a6e43428816
- one in "Open a Web Page"
Updated•14 years ago
|
Priority: -- → P1
| Assignee | ||
Comment 1•14 years ago
|
||
This patch fixes a couple of typoes, and clarifies that `uninstall` is never called on unload, which was another suggestion from Paul Morris on the list.
(By the way, it seems to me that bug 627432 is quite a serious bug, and worthy of more attention than it's been getting.)
Attachment #614429 -
Flags: review?(dcm)
Comment 2•14 years ago
|
||
Comment on attachment 614429 [details] [diff] [review]
a patch!
Looks good to me
Attachment #614429 -
Flags: review?(dcm) → review+
Comment 3•14 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/3c91e05b8b455109feb717f0eb81505c69290408
Bug 741620 - Typos in the docs; r=@dcm
| Assignee | ||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Comment 4•14 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/ecbcd1ece2b90c38aaad3af35750b4dbd3d30c9b
Bug 741620 - Typos in the docs; r=@dcm
(cherry picked from commit 3c91e05b8b455109feb717f0eb81505c69290408)
Comment 5•14 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk
https://github.com/mozilla/addon-sdk/commit/3c91e05b8b455109feb717f0eb81505c69290408
Bug 741620 - Typos in the docs; r=@dcm
You need to log in
before you can comment on or make changes to this bug.
Description
•