741702 - stop using QueryInterface in CAccessibleHyperlink

Status: RESOLVED DUPLICATE of bug 767264

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

same as bug 736252:

1) do static_cast<nsAccessible*>(this) instead do_QueryObject(this)
2) rename CAccessibleHyperlink to ia2AccessibleHyperlink

Comment 1

[Ye Kaiqi]

Want to get assigned

Comment 2

[alexander :surkov (:asurkov)]

(In reply to Ye Kaiqi from comment #1)
> Want to get assigned

done

Comment 3

[Ye Kaiqi]

(In reply to alexander :surkov from comment #2)
> done

Thanks!

Comment 4

[Ye Kaiqi]

Attachment: patch v1

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 613900 [details] [diff] [review]
patch v1

Review of attachment 613900 [details] [diff] [review]:
-----------------------------------------------------------------

remove QueryInterface from header

::: accessible/src/msaa/CAccessibleHyperlink.cpp
@@ +53,5 @@
>  {
>    *ppv = NULL;
>  
>    if (IID_IAccessibleHyperlink == iid) {
> +    nsRefPtr<nsAccessible> thisObj = static_cast<nsAccessible*>(this);

no nsRefPtr pls and everywhere below

Comment 6

[Ye Kaiqi]

(In reply to alexander :surkov from comment #5)
Thank you Alex for your help. I am trying to read the doc for nsRefPtr and other pointers to understand more. Hope in the future I will make fewer mistakes.

Comment 7

[Ye Kaiqi]

Attachment: patch v2

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Ye Kaiqi from comment #6)
> (In reply to alexander :surkov from comment #5)
> Thank you Alex for your help. I am trying to read the doc for nsRefPtr and
> other pointers to understand more. Hope in the future I will make fewer
> mistakes.

Yeah, sure. Perhaps it makes sense to build the patch before asking for feedback so you'll be told about mistasks by compiler :) Please try your last patch.

Comment 9

[alexander :surkov (:asurkov)]

Comment on attachment 613950 [details] [diff] [review]
patch v2


>--- a/accessible/src/msaa/CAccessibleHyperlink.cpp
>+++ b/accessible/src/msaa/CAccessibleHyperlink.cpp

btw, please rename CAccessibleHyperlink files into ia2AccessibleHyperlink. Don't forget to fix Makefile.in

Comment 10

[Ye Kaiqi]

Attachment: patch v3

Comment 11

[alexander :surkov (:asurkov)]

Comment on attachment 614015 [details] [diff] [review]
patch v3

you just remove those files (but you need to "hg rename" them)

Comment 12

[Ye Kaiqi]

(In reply to alexander :surkov from comment #11)
> Comment on attachment 614015 [details] [diff] [review]
> patch v3
> 
> you just remove those files (but you need to "hg rename" them)

Hi, Alex.
It seems that my "hg rename accessible/src/msaa/CAccessibleHyperlink.h accessible/src/msaa/ia2AccessibleHyperlink.h" does not find the file. I asked some people on irc, but still cannot fix it. :(

Comment 13

[alexander :surkov (:asurkov)]

(In reply to Ye Kaiqi from comment #12)

> It seems that my "hg rename accessible/src/msaa/CAccessibleHyperlink.h
> accessible/src/msaa/ia2AccessibleHyperlink.h" does not find the file. I
> asked some people on irc, but still cannot fix it. :(

I think this is because you removed them already. I'd recommend to start new patch since nothing useful excpet Makefile.in changes in existing patch (or alternatively try hg add)

Comment 14

[Ye Kaiqi]

> I think this is because you removed them already. I'd recommend to start new
> patch since nothing useful excpet Makefile.in changes in existing patch (or
> alternatively try hg add)

OK. I am trying that.

Comment 15

[alexander :surkov (:asurkov)]

was fixed by duping bug 767264