741704 - unable to delete review for disabled by administrator add-on

Status: RESOLVED WONTFIX

(addons.mozilla.org Graveyard :: Public Pages, enhancement, P5)

Description

[Nikolay S. Frantsev]

Attachment: Review for disabled add-on

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20100101 Firefox/11.0
Build ID: 20120314111819

Steps to reproduce:

1. Open my profile on AMO <https://addons.mozilla.org/en-US/firefox/user/33085/>.
2. Trying to delete last review <https://addons.mozilla.org/en-US/firefox/addon/ap-search-tools/reviews/243037/delete> for «disabled by administrator» add-on <https://addons.mozilla.org/en-US/firefox/addon/ap-search-tools/>.


Actual results:

Nothing with normal click.
«Not Found» error when opening delete link in new tab.


Expected results:

Review for disabled add-on should be deleted.

Comment 1

[Nikolay S. Frantsev]

Attachment: Disabled by administrator add-on

Comment 2

[Nikolay S. Frantsev]

Attachment: Not found page

Comment 3

[Rob Hudson [:robhudson]]

The 404 (rather than a 403) was a good clue. The reason is that the delete view has the @addon_view decorator which filters out non "valid" addons, which includes those that are "disabled by an administrator". So clicking the delete link results in a 404.

Should we either:

1) Remove the "Delete review" link (and "Edit review" link) from the user profile page, since disabled add-ons aren't seen anyway?  or
2) Fix the delete view to allow non "valid" addons to be deleted?

Comment 4

[Wil Clouser [:clouserw]]

I think we should not show reviews for disabled (read: non-valid) add-ons

Comment 5

[Nikolay S. Frantsev]

I agree, hiding comments in that way is a good solution.

Comment 6

[Wil Clouser [:clouserw]]

Thanks for filing this.  Due to resource constraints we are closing bugs which we won't realistically be able to fix.  If you have a patch that applies to this bug please reopen.

For more info see http://micropipes.com/blog/2014/09/24/the-great-add-on-bug-triage/