Closed Bug 741729 Opened 8 years ago Closed 8 years ago

Visually identify conversations with pending and direct messages

Categories

(Thunderbird :: Instant Messaging, enhancement)

13 Branch
enhancement
Not set

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: jb, Assigned: florian)

Details

Attachments

(3 files, 2 obsolete files)

The conversation list should adopt a color code to instantly identity conversations with unread and/or messages directed to the user. This would possibly complement or replace the current conversation status composed of 2 numbers in parenthesis representing direct and unread messages count.

For example, bold could be used to identify conversations having received new messages since last view, and bold blue for a direct message.
(In reply to Jb Piacentino from comment #0)

> For example, bold could be used to identify conversations having received
> new messages since last view, and bold blue for a direct message.

Would private conversations with new messages be bold or bold blue?

This seems simple to implement, but I would like to have a confirmation it will receive ui-r+ before starting to work on the patch. Blake?
I think just bold, since there's no need to highlight that they're private.
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → florian
Attachment #611844 - Flags: ui-review?(bwinton)
Attachment #611844 - Flags: review?(bwinton)
Attached image Screenshot
This doesn't look as good as I hoped as the bold conversation titles look like the section headers, but we can probably take this anyway.
(In reply to Florian Quèze from comment #4)
> Created attachment 611845 [details]
> Screenshot
> 
> This doesn't look as good as I hoped as the bold conversation titles look
> like the section headers, but we can probably take this anyway.

What if you give some indent to the conversations? That should make it easier to tell apart headers and conversations.
Attached image Screenshot 2
(In reply to Andreas Nilsson (:andreasn) from comment #5)
>
> What if you give some indent to the conversations? That should make it
> easier to tell apart headers and conversations.
Attached patch Patch for attachment 612175 (obsolete) — Splinter Review
I would line the icons up with the text on the previous line, but aside from that, it looks pretty good to me…
(In reply to Florian Quèze from comment #7)
> Created attachment 612178 [details] [diff] [review]
> Patch for attachment 612175 [details]

Instead of padding-left could you use -moz-padding-start? Then it would also work correct with rtl locales.
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #8)
> I would line the icons up with the text on the previous line, but aside from
> that, it looks pretty good to me…

Agreed!
Attached patch Patch v3Splinter Review
I lined the protocol icons with the above text by removing 2px of the margin before the text, and adding 3px to the padding before the icons.
Attachment #611844 - Attachment is obsolete: true
Attachment #612178 - Attachment is obsolete: true
Attachment #611844 - Flags: ui-review?(bwinton)
Attachment #611844 - Flags: review?(bwinton)
Attachment #613990 - Flags: ui-review?(bwinton)
Attachment #613990 - Flags: review?(bwinton)
Comment on attachment 613990 [details] [diff] [review]
Patch v3

Exactly what I was thinking of, UI-Wise.  ui-r=me!

And now for the terrible nit-picking of doom…

Nope, nothing to complain about here either.  r=me!

Thanks,
Blake.
Attachment #613990 - Flags: ui-review?(bwinton)
Attachment #613990 - Flags: ui-review+
Attachment #613990 - Flags: review?(bwinton)
Attachment #613990 - Flags: review+
http://hg.mozilla.org/comm-central/rev/230ad8d7722a
Severity: normal → enhancement
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Comment on attachment 613990 [details] [diff] [review]
Patch v3

[Approval Request Comment]
I think we will want this improvement to the chat UI on aurora too.
Attachment #613990 - Flags: approval-comm-aurora?
Attachment #613990 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.