Closed
Bug 741731
Opened 14 years ago
Closed 14 years ago
Platform auto-detection in scraper class should fallback to macosx64 for tinderbox builds on 10.6/10.7
Categories
(Mozilla QA Graveyard :: Mozmill Automation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
Details
Attachments
(1 file)
|
1.89 KB,
patch
|
davehunt
:
review+
|
Details | Diff | Splinter Review |
Right now we are trying to download builds for 'macosx' on 10.6/10.7. Those don't exist for en-US tinderbox builds. So we should fallback to 'macosx64' on those platforms.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #611767 -
Flags: review?(dave.hunt)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 611767 [details] [diff] [review]
Patch v1
In your comment you mention 'macosx64' whereas the code implies 'mac64'. Assuming this is a mistake in the comment or somehow otherwise irrelevant then r+ from me.
Attachment #611767 -
Flags: review?(dave.hunt) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
I don't mention 'macosx64' in the comment. It just says 64bit. So I assume nothing prevents me from landing this patch.
Landed as:
http://hg.mozilla.org/qa/mozmill-automation/rev/964b989a73d0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•14 years ago
|
||
I was referring to your comment in Bugzilla:
> So we should fallback to 'macosx64' on those platforms.
|
||
Updated•12 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•