741841 - Including a version range in a Plugin block shouldn't automatically add a targetApplication

Status: RESOLVED FIXED

(Toolkit :: Blocklist Policy Requests, defect, P1)

Description

[Jorge Villalobos [:jorgev] (he/him)]

I created this test block:
https://addons-dev.allizom.org/en-US/admin/models/blocklist/blocklistdetail/83/

Note the Blocklist Plugins section with min and max version. Also note I didn't specify a targetApplication

The downloaded blocklist item ends up being this:

> <pluginItem  blockID="p83">
>   <match name="filename" exp="(JavaPlugin2_NPAPI\.plugin)|(JavaAppletPlugin\.plugin)"
>   />
>   <versionRange  severity="1">
>     <targetApplication id="%7Bec8030f7-c20a-464f-9b0e-13a3a9e97384%7D">
>       <versionRange  minVersion="0" maxVersion="14.1.0" />
>     </targetApplication>
>   </versionRange>
> </pluginItem>

What I expected was this:

> <pluginItem  blockID="p83">
>   <match name="filename" exp="(JavaPlugin2_NPAPI\.plugin)|(JavaAppletPlugin\.plugin)"
>   />
>   <versionRange  severity="1" minVersion="0" maxVersion="14.1.0">
>   </versionRange>
> </pluginItem>

There should be no target application, and the min and max versions should apply to the parent versionRange node.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/1fc8f15