Chat - too much empty space after each line

RESOLVED WORKSFORME

Status

Thunderbird
Theme
RESOLVED WORKSFORME
6 years ago
6 years ago

People

(Reporter: andreasn, Unassigned)

Tracking

Trunk
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Florian noticed it looks a bit odd with the empty space after each line.
http://i.imgur.com/d6nY4.png
Blocks: 735995
I tried to fix this by changing this rule
.message {
  min-height: 30px;
}


to
.bubble.message {
  min-height: 30px;
}

or
.messagepart {
  min-height: 50px;
}

but it didn't give a really satisfying result.
(Reporter)

Comment 2

6 years ago
.messagepart {
  min-height: 50px;
}

What made you disatisfied about that approach?
I think it looks good with min-height: 55px; so I'll attach a patch for that.
(Reporter)

Comment 3

6 years ago
Created attachment 612153 [details] [diff] [review]
chat space fix
Attachment #612153 - Flags: feedback?(florian)
Created attachment 612155 [details]
Screenshot of attachment 612153 [details] [diff] [review]

(In reply to Andreas Nilsson (:andreasn) from comment #2)
> .messagepart {
>   min-height: 50px;
> }
> 
> What made you disatisfied about that approach?
> I think it looks good with min-height: 55px; so I'll attach a patch for that.

I'm attaching a screenshot to answer your question. The screenshot is with your patch applied, and with the content selected to clearly see where paddings are. In the first bubble you can see that with min-height: 55px, we have too much space under the avatar, regressing bug 742235 even more. With min-height: 50px, the first bubble (containing only one message) looks OKish, but in the second bubble, the first horizontal ruler almost touches the avatar.
(Reporter)

Comment 5

6 years ago
Created attachment 616245 [details] [diff] [review]
new approach

Lets see if this works any better.
Attachment #616245 - Flags: feedback?(florian)
Attachment #612153 - Attachment is obsolete: true
Attachment #612153 - Flags: feedback?(florian)
Comment on attachment 616245 [details] [diff] [review]
new approach

Seems ok. I still feel that there's an excessive amount of padding, especially in system messages, but at least now they are well balanced. And I guess reducing the space used on the screen is more the topic of bug 742235.
Attachment #616245 - Flags: feedback?(florian) → feedback+
(Reporter)

Comment 7

6 years ago
Comment on attachment 616245 [details] [diff] [review]
new approach

setting up for review
Attachment #616245 - Flags: ui-review?(bwinton)
Attachment #616245 - Flags: review?(florian)
(Reporter)

Comment 8

6 years ago
Comment on attachment 616245 [details] [diff] [review]
new approach

Canceling review as we're already good now after #742235 have landed. (lines are now 29px high).
Attachment #616245 - Flags: ui-review?(bwinton)
Attachment #616245 - Flags: review?(florian)
(Reporter)

Comment 9

6 years ago
http://i.imgur.com/SJKwG.png
From left to right:
1. Before this or the patch in bug #742235 was applied
2. With the patch in this bug applied
3. With patch in bug #742235 applied.

Please reopen if this still happens.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.