Last Comment Bug 741865 - Disable Test Pilot Logging by default
: Disable Test Pilot Logging by default
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 16.0
Assigned To: :Irving Reid (No longer working on Firefox)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-03 10:21 PDT by Mark Banner (:standard8, afk until Dec)
Modified: 2012-06-09 07:25 PDT (History)
3 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Set Test Pilot log4moz default to Error and add preferences to adjust (8.50 KB, patch)
2012-05-01 09:13 PDT, :Irving Reid (No longer working on Firefox)
standard8: review+
Details | Diff | Splinter Review

Description Mark Banner (:standard8, afk until Dec) 2012-04-03 10:21:21 PDT
Currently it appears that test pilot has logging enabled by default, there's no reason for this on user's system, if we're seeing a systematic error, we can request logging is turned on.
Comment 1 Mark Banner (:standard8, afk until Dec) 2012-04-17 13:10:14 PDT
Irving, can you take a look at this please? I think you want to look in modules/setup.js, there's log4moz.js used there. We probably just want to incorporate a hidden pref(s) like we've done in other places in the mail/mailnews code.
Comment 2 :Irving Reid (No longer working on Firefox) 2012-05-01 09:13:23 PDT
Created attachment 619950 [details] [diff] [review]
Set Test Pilot log4moz default to Error and add preferences to adjust

Change default Log4Moz level to Error, and add string preferences:

extensions.testpilot.loader.log
extensions.testpilot.setup.log

that can be set to other levels (Trace, Debug, Info, Warn, Error, Fatal, All)

Test Pilot should probably either switch to using the build-in version of Log4Moz in services/common, or import the recent changes from that file.

It would also be interesting to merge in some of the changes that were made in the Thunderbird/gloda version of Log4Moz, including building log preference handling directly into Log4Moz instead of making the client code handle it.

Also in this patch is a drive-by conversion of setup.js to use Services.jsm to get handles to XPCOM services it needs.
Comment 3 :Irving Reid (No longer working on Firefox) 2012-06-07 12:53:29 PDT
Comment on attachment 619950 [details] [diff] [review]
Set Test Pilot log4moz default to Error and add preferences to adjust

cancel superreview request after IRC conversation with gregglind
Comment 4 Ryan VanderMeulen [:RyanVM] 2012-06-09 07:25:51 PDT
https://hg.mozilla.org/comm-central/rev/d868e340d465

Note You need to log in before you can comment on or make changes to this bug.