Disable Test Pilot Logging by default

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: standard8, Assigned: Irving)

Tracking

Trunk
Thunderbird 16.0
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Currently it appears that test pilot has logging enabled by default, there's no reason for this on user's system, if we're seeing a systematic error, we can request logging is turned on.
Irving, can you take a look at this please? I think you want to look in modules/setup.js, there's log4moz.js used there. We probably just want to incorporate a hidden pref(s) like we've done in other places in the mail/mailnews code.
Assignee: nobody → irving
Created attachment 619950 [details] [diff] [review]
Set Test Pilot log4moz default to Error and add preferences to adjust

Change default Log4Moz level to Error, and add string preferences:

extensions.testpilot.loader.log
extensions.testpilot.setup.log

that can be set to other levels (Trace, Debug, Info, Warn, Error, Fatal, All)

Test Pilot should probably either switch to using the build-in version of Log4Moz in services/common, or import the recent changes from that file.

It would also be interesting to merge in some of the changes that were made in the Thunderbird/gloda version of Log4Moz, including building log preference handling directly into Log4Moz instead of making the client code handle it.

Also in this patch is a drive-by conversion of setup.js to use Services.jsm to get handles to XPCOM services it needs.
Attachment #619950 - Flags: superreview?(glind)
Attachment #619950 - Flags: review?(mbanner)
Status: NEW → ASSIGNED
Attachment #619950 - Flags: review?(mbanner) → review+
Comment on attachment 619950 [details] [diff] [review]
Set Test Pilot log4moz default to Error and add preferences to adjust

cancel superreview request after IRC conversation with gregglind
Attachment #619950 - Flags: superreview?(glind)
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/d868e340d465
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.