Closed
Bug 741989
Opened 13 years ago
Closed 13 years ago
Add optional argument to specify adb path to devicemanagerADB.py
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla14
People
(Reporter: jgriffin, Assigned: jgriffin)
Details
Attachments
(1 file, 1 obsolete file)
2.11 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
Currently, DeviceManagerADB assumes that 'adb' is on the path. For B2G CI, this isn't true; adb is produced as part of the build.
This patch (formerly folded into bug 741479) adds an optional argument to DeviceManagerADB to specify the adb path. If not specified, the current behavior of assuming it is on the PATH remains unchanged.
Attachment #611914 -
Flags: review?(wlachance)
Assignee | ||
Updated•13 years ago
|
Attachment #611914 -
Flags: review?(jmaher)
Comment 1•13 years ago
|
||
Comment on attachment 611914 [details] [diff] [review]
patch
Review of attachment 611914 [details] [diff] [review]:
-----------------------------------------------------------------
if we can add in a verification of the adbpath to ensure it is valid, I think this would be complete. Either in an updated patch or a new bug.
Attachment #611914 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 2•13 years ago
|
||
This adds verification that any adbPath passed is a valid executable.
Attachment #611914 -
Attachment is obsolete: true
Attachment #611914 -
Flags: review?(wlachance)
Attachment #612057 -
Flags: review?(jmaher)
Comment 3•13 years ago
|
||
Comment on attachment 612057 [details] [diff] [review]
patch v0.2
Review of attachment 612057 [details] [diff] [review]:
-----------------------------------------------------------------
thanks!
Attachment #612057 -
Flags: review?(jmaher) → review+
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → jgriffin
Assignee | ||
Comment 4•13 years ago
|
||
Target Milestone: --- → mozilla14
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•