742070 - Unable to complete app submission if default locale in the manifest is not English

Status: RESOLVED WORKSFORME

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[krupa raj[:krupa]]

For the initial developer preview, we only supported en-US and therefore suppressed bugs about other locales. See bug 730005

steps to reproduce:
1. Try to upload https://people.mozilla.org/~kraj/test-files/webapps/webapp-with-de-as-default-locale.webapp
2. Fill in all the necessary fields in Step 3 and click continue




observed behavior:
If default locale in the manifest is not set to English, user is stuck on Step 3.

For beta since we support other locales, we need to fix this.

Comment 1

[Christopher Van Wiemeersch [:cvan]]

I believe this happened. And I saw this happen. But can you reproduce this now? I cannot seem to using http://people.mozilla.org/~kraj/test-files/webapps/webapp-with-de-as-default-locale.webapp

Comment 2

[Wil Clouser [:clouserw]]

resolving for verification

Comment 3

[krupa raj[:krupa]]

This is happening again at https://marketplace-dev.allizom.org/en-US/developers/submit/app/details/seavans-undersea-adventure--9

reopening

Comment 4

[krupa raj[:krupa]]

This does not allow developer to upload any more apps until they clear their loclaStorage.

Comment 5

[Allen Short [:ashort]]

What's going on, as far as I can tell, is that you can't submit the form if the manifest locale and your browser locale disagree. The trouble shows up in `translations.widgets.TransMulti.value_from_datadict` -- the posted data has keys like `privacy_policy_en_us` but the form is looking for `privacy_policy_de` since that's what the webapp's `default_locale` is set to.

Comment 6

[Allen Short [:ashort]]

https://github.com/mozilla/zamboni/commit/013a5028a6becd129b08fd487271bd92b0fe7603

Comment 7

[Kumar McMillan [:kumar]]

krupa, once qa verifies this we should probably do a bugfix release. Thanks ashort!

Comment 8

[krupa raj[:krupa]]

This is not fixed. I am still stuck at Step 3 of submission. See https://marketplace-dev.allizom.org/en-US/developers/submit/app/details/test-webapp-7

Comment 9

[Allen Short [:ashort]]

This works on marketplace-dev. if you're still having the problem, see if clearing localStorage makes a difference.