Closed
Bug 742186
Opened 12 years ago
Closed 12 years ago
Handle callbacks that are not nullable correctly
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bzbarsky, Unassigned)
References
(Blocks 1 open bug)
Details
This applies to callbacks (not callback interfaces). Right now both unwrapping and wrapping assume nullability without failing codegen if it's not present. We should fix that.
Reporter | ||
Comment 1•12 years ago
|
||
Unwrapping got addressed in bug 792137. Not sure how much we care about wrapping. The obvious change to wrapping would be to use ObjectValue() when not nullable, but I'm not sure there's a win to be had there over using ObjectOrNullValue() no matter what.
Depends on: 792137
Reporter | ||
Comment 2•12 years ago
|
||
Once I land bug 779048, we'll see what remains to be done here.
Depends on: 779048
Reporter | ||
Comment 3•12 years ago
|
||
This is fully fixed now, with a null-check on the CallbackFunction* and everything, in bug 779048.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•