Last Comment Bug 742250 - Conversation items should be selectable without the mouse
: Conversation items should be selectable without the mouse
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: unspecified
: x86 All
-- normal (vote)
: Thunderbird 17.0
Assigned To: Florian Quèze [:florian] [:flo]
Depends on:
  Show dependency treegraph
Reported: 2012-04-04 03:43 PDT by Fabien Cazenave [:kaze]
Modified: 2012-07-23 13:02 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

Patch (1.85 KB, patch)
2012-07-17 05:42 PDT, Florian Quèze [:florian] [:flo]
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review
Patch v2 (for check-in) (1.78 KB, patch)
2012-07-23 10:38 PDT, Florian Quèze [:florian] [:flo]
bwinton: approval‑comm‑aurora+
bwinton: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Fabien Cazenave [:kaze] 2012-04-04 03:43:51 PDT
All IM/IRC clients allow to switch conversations with a keyboard shortcut. Thunderbird does not, I see that as an accessibility issue (and a major PITA for most users).

All IM/IRC clients also allow to reorder conversations, precisely to ease the keyboard selection.

I can suggest these keyboard shortcuts:
 * accel + up/down = select previous/next conversation
 * accel + shift + up/down = move current conversation up/down
Comment 1 User image Fabien Cazenave [:kaze] 2012-04-05 00:11:45 PDT
Oh, and we really need a way to jump to the next unread discussion, too (e.g. accel + return), with a higher priority to discussion with highlights or private messages.
Comment 2 User image Florian Quèze [:florian] [:flo] 2012-07-17 05:42:49 PDT
Created attachment 642918 [details] [diff] [review]

This patch adds an accel + up/down keyboard shortcut to select the previous/next item in the left pane. When a conversation is selected, the focus is immediately moved to the input box, otherwise the focus goes to the listbox.
Comment 3 User image Blake Winton (:bwinton) (:☕️) 2012-07-23 10:12:33 PDT
Comment on attachment 642918 [details] [diff] [review]

UI-wise I like it.  ui-r=me.

>+++ b/mail/components/im/content/chat-messenger-overlay.js
>@@ -940,16 +940,31 @@ var chatHandler = {
>+    document.getElementById("chatTabPanel").addEventListener("keypress", function(aEvent) {
>+      let isMac = "nsILocalFileMac" in Components.interfaces;

Can't you use Application.platformIsMac here?

>+      let accelKeyPressed = isMac ? aEvent.metaKey : aEvent.ctrlKey;
>+      if (!accelKeyPressed || // == listbox ||

Remove the stuff after "//", please.

Other than that, it seems fine to me, so r=me with those fixed.

Comment 4 User image Florian Quèze [:florian] [:flo] 2012-07-23 10:38:31 PDT
Created attachment 644975 [details] [diff] [review]
Patch v2 (for check-in)

Addressed Blake's 2 points in comment 3.
Comment 5 User image Blake Winton (:bwinton) (:☕️) 2012-07-23 11:58:12 PDT
Comment on attachment 644975 [details] [diff] [review]
Patch v2 (for check-in)

Yeah, I really think we want to have this on aurora/beta.
Comment 7 User image Mike Conley (:mconley) 2012-07-23 13:02:22 PDT
Backed out of comm-beta since we landed on a SeaMonkey relbranch (oops).

Re-landed on comm-beta as:

Note You need to log in before you can comment on or make changes to this bug.