Conversation items should be selectable without the mouse

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: kaze, Assigned: florian)

Tracking

unspecified
Thunderbird 17.0
x86
All

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
All IM/IRC clients allow to switch conversations with a keyboard shortcut. Thunderbird does not, I see that as an accessibility issue (and a major PITA for most users).

All IM/IRC clients also allow to reorder conversations, precisely to ease the keyboard selection.

I can suggest these keyboard shortcuts:
 * accel + up/down = select previous/next conversation
 * accel + shift + up/down = move current conversation up/down
(Reporter)

Comment 1

6 years ago
Oh, and we really need a way to jump to the next unread discussion, too (e.g. accel + return), with a higher priority to discussion with highlights or private messages.
(Assignee)

Comment 2

5 years ago
Created attachment 642918 [details] [diff] [review]
Patch

This patch adds an accel + up/down keyboard shortcut to select the previous/next item in the left pane. When a conversation is selected, the focus is immediately moved to the input box, otherwise the focus goes to the listbox.
Assignee: nobody → florian
Attachment #642918 - Flags: ui-review?(bwinton)
Attachment #642918 - Flags: review?(bwinton)
Comment on attachment 642918 [details] [diff] [review]
Patch

UI-wise I like it.  ui-r=me.

>+++ b/mail/components/im/content/chat-messenger-overlay.js
>@@ -940,16 +940,31 @@ var chatHandler = {
>+    document.getElementById("chatTabPanel").addEventListener("keypress", function(aEvent) {
>+      let isMac = "nsILocalFileMac" in Components.interfaces;

Can't you use Application.platformIsMac here?

>+      let accelKeyPressed = isMac ? aEvent.metaKey : aEvent.ctrlKey;
>+      if (!accelKeyPressed || //aEvent.target == listbox ||

Remove the stuff after "//", please.

Other than that, it seems fine to me, so r=me with those fixed.

Thanks,
Blake.
Attachment #642918 - Flags: ui-review?(bwinton)
Attachment #642918 - Flags: ui-review+
Attachment #642918 - Flags: review?(bwinton)
Attachment #642918 - Flags: review+
(Assignee)

Comment 4

5 years ago
Created attachment 644975 [details] [diff] [review]
Patch v2 (for check-in)

Addressed Blake's 2 points in comment 3.
Attachment #644975 - Flags: approval-comm-beta?
Attachment #644975 - Flags: approval-comm-aurora?
Comment on attachment 644975 [details] [diff] [review]
Patch v2 (for check-in)

Yeah, I really think we want to have this on aurora/beta.
Attachment #644975 - Flags: approval-comm-beta?
Attachment #644975 - Flags: approval-comm-beta+
Attachment #644975 - Flags: approval-comm-aurora?
Attachment #644975 - Flags: approval-comm-aurora+

Updated

5 years ago
Attachment #642918 - Attachment is obsolete: true

Updated

5 years ago
Keywords: checkin-needed

Updated

5 years ago
Keywords: checkin-needed
comm-central: https://hg.mozilla.org/comm-central/rev/332fdeb276a1
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/e41c6af2dac6
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/add591780b0f
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
OS: Linux → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Backed out of comm-beta since we landed on a SeaMonkey relbranch (oops).

Re-landed on comm-beta as: https://hg.mozilla.org/releases/comm-beta/rev/5ea717127777
You need to log in before you can comment on or make changes to this bug.