742250 - Conversation items should be selectable without the mouse

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Fabien Cazenave [:kaze]]

All IM/IRC clients allow to switch conversations with a keyboard shortcut. Thunderbird does not, I see that as an accessibility issue (and a major PITA for most users).

All IM/IRC clients also allow to reorder conversations, precisely to ease the keyboard selection.

I can suggest these keyboard shortcuts:
 * accel + up/down = select previous/next conversation
 * accel + shift + up/down = move current conversation up/down

Comment 1

[Fabien Cazenave [:kaze]]

Oh, and we really need a way to jump to the next unread discussion, too (e.g. accel + return), with a higher priority to discussion with highlights or private messages.

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch

This patch adds an accel + up/down keyboard shortcut to select the previous/next item in the left pane. When a conversation is selected, the focus is immediately moved to the input box, otherwise the focus goes to the listbox.

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 642918 [details] [diff] [review]
Patch

UI-wise I like it.  ui-r=me.

>+++ b/mail/components/im/content/chat-messenger-overlay.js
>@@ -940,16 +940,31 @@ var chatHandler = {
>+    document.getElementById("chatTabPanel").addEventListener("keypress", function(aEvent) {
>+      let isMac = "nsILocalFileMac" in Components.interfaces;

Can't you use Application.platformIsMac here?

>+      let accelKeyPressed = isMac ? aEvent.metaKey : aEvent.ctrlKey;
>+      if (!accelKeyPressed || //aEvent.target == listbox ||

Remove the stuff after "//", please.

Other than that, it seems fine to me, so r=me with those fixed.

Thanks,
Blake.

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch v2 (for check-in)

Addressed Blake's 2 points in comment 3.

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 644975 [details] [diff] [review]
Patch v2 (for check-in)

Yeah, I really think we want to have this on aurora/beta.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

comm-central: https://hg.mozilla.org/comm-central/rev/332fdeb276a1
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/e41c6af2dac6
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/add591780b0f

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Backed out of comm-beta since we landed on a SeaMonkey relbranch (oops).

Re-landed on comm-beta as: https://hg.mozilla.org/releases/comm-beta/rev/5ea717127777