7423 - HTTP-Equiv charset handling is not working

Status: VERIFIED FIXED

(Core :: Internationalization, defect, P1)

Description

[Katsuhiko Momoi]

** Observed with 6/1/99 Win32 build **

With this M7 build, go visit a page which has a meta charset tag.
It should load correctly in one try. This is not the case.
You're able to see a page like this with the first load with a
build from a few days ago. This mechanism is not working properly with the
build above.

Comment 1

[Frank Tang]

This is caused by a bug in nsStr.cpp FindCharInSet. The following code should
fix it.

Index: nsStr.cpp
===================================================================
RCS file: /m/pub/mozilla/xpcom/ds/nsStr.cpp,v
retrieving revision 1.16
diff -c -r1.16 nsStr.cpp
*** nsStr.cpp   1999/05/29 09:40:49     1.16
--- nsStr.cpp   1999/06/01 23:40:48
***************
*** 495,501 ****

    while(++index<aDest.mLength) {
      PRUnichar theChar=GetCharAt(aDest,index);
!     thePos=gFindChars[aSet.mCharSize](aSet.mStr,aSet.mLength,anOffset,theChar,
      if(kNotFound!=thePos)
        return index;
    } //while
--- 495,501 ----

    while(++index<aDest.mLength) {
      PRUnichar theChar=GetCharAt(aDest,index);
!     thePos=gFindChars[aSet.mCharSize](aSet.mStr,aSet.mLength,0,theChar,aIgnore
      if(kNotFound!=thePos)
        return index;
    } //while
***************
*** 569,575 ****

    while(--offset>=0) {
      PRUnichar theChar=GetCharAt(aDest,offset);
!     thePos=gRFindChars[aSet.mCharSize](aSet.mStr,aSet.mLength,anOffset,theChar
      if(kNotFound!=thePos)
        return offset;
    } //while
--- 569,575 ----

    while(--offset>=0) {
      PRUnichar theChar=GetCharAt(aDest,offset);
!     thePos=gRFindChars[aSet.mCharSize](aSet.mStr,aSet.mLength,0,theChar,aIgnor
      if(kNotFound!=thePos)
        return offset;
    } //while

Reassign this to rickg.

Comment 2

[rickg]

Fixed

Comment 3

[Teruko Kobayashi]

I verified this in 6-10-09 build.