742459 - Converting between storage service providers does not remove the old attachment URL

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR (affects both plaintext and HTML mail):

1)  Compose a new mail, and attach a Filelink for Dropbox
2)  Convert the Filelink to use YouSendIt instead

What happens?

The old Filelink URL remains in the body of the message.  When the conversion completes, the new URL is appended, and the old one still persists.

What should happen?

When converting, the old attachment URL should go away permanently.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

First run at it, includes tests.

Comment 2

[David :Bienvenu]

this patch doesn't apply - does the patch for 742538 need to go first? Or vice versa?

Comment 3

[David :Bienvenu]

Comment on attachment 612591 [details] [diff] [review]
Patch v1

+/**
+ * Test that if we convert a Filelink from one provider to another, that the
+ * old Filelink is removed, and a new Filelink is added for the new provider.
+ */

This tests both html and plain text compose, right? Probably should add that to the comment.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2 (carrying over r+ from bienvenu)

Comment fixed and patch un-bitrotted.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-central as http://hg.mozilla.org/comm-central/rev/de274c897ab7

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/458415218fb7