Converting between storage service providers does not remove the old attachment URL

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Trunk
Thunderbird 14.0
x86
All
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

STR (affects both plaintext and HTML mail):

1)  Compose a new mail, and attach a Filelink for Dropbox
2)  Convert the Filelink to use YouSendIt instead

What happens?

The old Filelink URL remains in the body of the message.  When the conversion completes, the new URL is appended, and the old one still persists.

What should happen?

When converting, the old attachment URL should go away permanently.
Assignee: nobody → mconley
Created attachment 612591 [details] [diff] [review]
Patch v1

First run at it, includes tests.
Attachment #612591 - Flags: review?(dbienvenu)
Blocks: 742538

Comment 2

5 years ago
this patch doesn't apply - does the patch for 742538 need to go first? Or vice versa?
Depends on: 738299

Comment 3

5 years ago
Comment on attachment 612591 [details] [diff] [review]
Patch v1

+/**
+ * Test that if we convert a Filelink from one provider to another, that the
+ * old Filelink is removed, and a new Filelink is added for the new provider.
+ */

This tests both html and plain text compose, right? Probably should add that to the comment.
Attachment #612591 - Flags: review?(dbienvenu) → review+
Created attachment 615366 [details] [diff] [review]
Patch v2 (carrying over r+ from bienvenu)

Comment fixed and patch un-bitrotted.
Attachment #612591 - Attachment is obsolete: true
Attachment #615366 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/de274c897ab7
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0

Updated

5 years ago
Attachment #615366 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/458415218fb7
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.