Closed Bug 742538 Opened 9 years ago Closed 9 years ago

Removing Filelink's from message body causes subsequent Filelink insertions to fail

Categories

(Thunderbird :: Message Compose Window, defect)

x86
All
defect
Not set
normal

Tracking

(thunderbird13 fixed)

RESOLVED FIXED
Thunderbird 14.0
Tracking Status
thunderbird13 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file, 2 obsolete files)

STR:

1)  In either HTML or Plaintext, create a Filelink
2)  Remove the Filelink from the message body
3)  Create another Filelink

What happens?

No Filelink gets inserted into the message body.

What's expected?

If the root/list nodes are not found in the message body, we should re-insert them.
Assignee: nobody → mconley
Attached patch WIP Patch v1 (obsolete) — Splinter Review
Attachment #612532 - Flags: ui-review?(bwinton)
Attachment #612532 - Flags: ui-review?(bwinton)
Attached patch Patch v1 (obsolete) — Splinter Review
Attachment #612532 - Attachment is obsolete: true
Attachment #612593 - Flags: review?(dbienvenu)
This patch depends on the patch for bug 742459.
Depends on: 742459
Comment on attachment 612593 [details] [diff] [review]
Patch v1

very nice - my one nit would be naming the method "assertIDsFree" since "assert" in our code generally has a different meaning. Maybe clearNodeIDs? resetNodeIDs?
Attachment #612593 - Flags: review?(dbienvenu) → review+
Thanks!  Renamed function to "_resetNodeIDs", and fixed some bitrot.

-Mike
Attachment #612593 - Attachment is obsolete: true
Attachment #615364 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/974245c3a39b
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Attachment #615364 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.