The default bug view has changed. See this FAQ.

Removing Filelink's from message body causes subsequent Filelink insertions to fail

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Trunk
Thunderbird 14.0
x86
All
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

STR:

1)  In either HTML or Plaintext, create a Filelink
2)  Remove the Filelink from the message body
3)  Create another Filelink

What happens?

No Filelink gets inserted into the message body.

What's expected?

If the root/list nodes are not found in the message body, we should re-insert them.
Assignee: nobody → mconley
Created attachment 612532 [details] [diff] [review]
WIP Patch v1
Attachment #612532 - Flags: ui-review?(bwinton)
Attachment #612532 - Flags: ui-review?(bwinton)
Created attachment 612593 [details] [diff] [review]
Patch v1
Attachment #612532 - Attachment is obsolete: true
Attachment #612593 - Flags: review?(dbienvenu)
This patch depends on the patch for bug 742459.
Depends on: 742459

Comment 4

5 years ago
Comment on attachment 612593 [details] [diff] [review]
Patch v1

very nice - my one nit would be naming the method "assertIDsFree" since "assert" in our code generally has a different meaning. Maybe clearNodeIDs? resetNodeIDs?
Attachment #612593 - Flags: review?(dbienvenu) → review+
Created attachment 615364 [details] [diff] [review]
Patch v2 (carrying over r+ from bienvenu)

Thanks!  Renamed function to "_resetNodeIDs", and fixed some bitrot.

-Mike
Attachment #612593 - Attachment is obsolete: true
Attachment #615364 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/974245c3a39b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/9a3c572d0568
status-thunderbird13: --- → fixed

Updated

5 years ago
Attachment #615364 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.