742593 - SetupSyncActivity does main thread networking

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Richard Newman [:rnewman]]

04-04 17:04:43.630 I/ActivityManager(  168): Displayed org.mozilla.fennec_rnewman/org.mozilla.gecko.sync.setup.activities.SetupSyncActivity: +208ms
04-04 17:04:43.630 D/OpenGLRenderer(14101): Flushing caches (mode 0)
04-04 17:04:43.970 D/dalvikvm(15565): GC_CONCURRENT freed 279K, 6% free 6928K/7303K, paused 1ms+2ms
04-04 17:04:44.200 E/JPakeCrypto(15565): myhash: 1869d70da68ebff5be89c44f66b3ad6e9d4b24bc8e7614f653cd5e679c56a16d
04-04 17:04:44.230 E/JPakeCrypto(15565): myhash: a78c558cf1f5e64de488540dfd4cd148b6b334daa6f036ff5631bfa01df11f52
04-04 17:04:44.270 D/dalvikvm(15565): GC_CONCURRENT freed 219K, 6% free 7103K/7495K, paused 2ms+2ms
04-04 17:04:45.970 I/ActivityManager(  168): START {flg=0x10000 cmp=org.mozilla.fennec_rnewman/org.mozilla.gecko.sync.setup.activities.AccountActivity} from pid 15565
04-04 17:04:46.010 D/AndroidRuntime(15565): Shutting down VM
04-04 17:04:46.010 W/dalvikvm(15565): threadid=1: thread exiting with uncaught exception (group=0x40a311f8)
04-04 17:04:46.030 E/AndroidRuntime(15565): FATAL EXCEPTION: main
04-04 17:04:46.030 E/AndroidRuntime(15565): java.lang.RuntimeException: Unable to pause activity {org.mozilla.fennec_rnewman/org.mozilla.gecko.sync.setup.activities.SetupSyncActivity}: android.os.NetworkOnMainThreadException
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.ActivityThread.performPauseActivity(ActivityThread.java:2706)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.ActivityThread.performPauseActivity(ActivityThread.java:2662)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:2640)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.ActivityThread.access$800(ActivityThread.java:123)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1154)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.os.Handler.dispatchMessage(Handler.java:99)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.os.Looper.loop(Looper.java:137)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.ActivityThread.main(ActivityThread.java:4424)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at java.lang.reflect.Method.invokeNative(Native Method)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at java.lang.reflect.Method.invoke(Method.java:511)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:784)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:551)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at dalvik.system.NativeStart.main(Native Method)
04-04 17:04:46.030 E/AndroidRuntime(15565): Caused by: android.os.NetworkOnMainThreadException
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1099)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at org.apache.harmony.xnet.provider.jsse.OpenSSLSocketImpl.close(OpenSSLSocketImpl.java:922)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.SocketHttpClientConnection.shutdown(SocketHttpClientConnection.java:234)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.conn.DefaultClientConnection.shutdown(DefaultClientConnection.java:151)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.conn.AbstractPooledConnAdapter.shutdown(AbstractPooledConnAdapter.java:163)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.conn.AbstractClientConnAdapter.abortConnection(AbstractClientConnAdapter.java:319)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.client.DefaultRequestDirector.abortConnection(DefaultRequestDirector.java:1158)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.client.DefaultRequestDirector.execute(DefaultRequestDirector.java:554)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:818)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at ch.boye.httpclientandroidlib.impl.client.AbstractHttpClient.execute(AbstractHttpClient.java:752)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at org.mozilla.gecko.sync.net.BaseResource.execute(BaseResource.java:247)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at org.mozilla.gecko.sync.net.BaseResource.go(BaseResource.java:275)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at org.mozilla.gecko.sync.net.BaseResource.delete(BaseResource.java:287)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at org.mozilla.gecko.sync.jpake.stage.DeleteChannel.execute(DeleteChannel.java:88)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at org.mozilla.gecko.sync.jpake.JPakeClient.abort(JPakeClient.java:247)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at org.mozilla.gecko.sync.setup.activities.SetupSyncActivity.onPause(SetupSyncActivity.java:153)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.Activity.performPause(Activity.java:4563)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1195)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	at android.app.ActivityThread.performPauseActivity(ActivityThread.java:2693)
04-04 17:04:46.030 E/AndroidRuntime(15565): 	... 12 more

Comment 1

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5ae07a2cc4ce

I cherry-picked this from one of Chenxia's branches.

Comment 2

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/5ae07a2cc4ce