IRC members list not sorted alphabetically

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: aryx, Assigned: mconley)

Tracking

Trunk
Thunderbird 17.0
x86
Windows XP

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Created attachment 612498 [details]
IRC members list

Thunderbird Daily 2012-04-04, Windows XP SP 3 32-bit

The list of members of an IRC channel is not sorted alphabetically, see attached screenshot.
Blocks: 740280
Are there additional steps to reproduce? The lists I see in my Thunderbird are sorted correctly.
Unfortunately not. I played with quitting and rejoining and later found the result shown in the screenshot.
I found a way to reproduce: this happens when clicking on the "Conversations" line (the very first item in the list of the left pane) and then selecting a chat room again.
(Assignee)

Comment 4

5 years ago
Gonna see if I can help Florian out by grabbing this one.
Assignee: nobody → mconley
(Assignee)

Comment 5

5 years ago
Alright, I think I've figured this one out - the pane's contacts are being sorted via insertion sort in imconversation.xml in addNick.

addNick relies on the listbox "nicklist" having a reliable count.

At the time of switching from the "Conversation" line in the left pane, the nicklist is hidden, and so we're unable to get a proper count (since apparently listbox will only give us a proper count when the item is visible).

So we simply need to make the contextPane visible before we list the participants. Patch is up next.
(Assignee)

Comment 6

5 years ago
Created attachment 642745 [details] [diff] [review]
Patch v1
Attachment #642745 - Flags: review?(florian)
(In reply to Mike Conley (:mconley) from comment #6)
> Created attachment 642745 [details] [diff] [review]
> Patch v1

What about just moving this line http://hg.mozilla.org/comm-central/annotate/f71ece130895/mail/components/im/content/chat-messenger-overlay.js#l592 to line 496?
(Assignee)

Comment 8

5 years ago
Created attachment 643030 [details] [diff] [review]
Patch v2

As suggested here and in IRC, I've moved the code that makes the contextPane visible from the bottom of the function to closer to the top.
Attachment #642745 - Attachment is obsolete: true
Attachment #642745 - Flags: review?(florian)
Attachment #643030 - Flags: review?(florian)
Comment on attachment 643030 [details] [diff] [review]
Patch v2

Looks good, thanks! Note: I haven't tested this patch, I assume you have or will before the check-in.
Attachment #643030 - Flags: review?(florian) → review+
(Assignee)

Comment 10

5 years ago
(In reply to Florian Quèze from comment #9)
> Comment on attachment 643030 [details] [diff] [review]
> Patch v2
> 
> Looks good, thanks! Note: I haven't tested this patch, I assume you have or
> will before the check-in.

Yes, manually tested.
(Assignee)

Updated

5 years ago
Attachment #643030 - Flags: approval-comm-beta?
Attachment #643030 - Flags: approval-comm-aurora?
Attachment #643030 - Flags: approval-comm-beta?
Attachment #643030 - Flags: approval-comm-beta+
Attachment #643030 - Flags: approval-comm-aurora?
Attachment #643030 - Flags: approval-comm-aurora+
(Assignee)

Comment 11

5 years ago
comm-central: https://hg.mozilla.org/comm-central/rev/2b1cde1b7369
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/41952791300e
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/794f909e43f8
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.