Created attachment 612498 [details]
IRC members list
Thunderbird Daily 2012-04-04, Windows XP SP 3 32-bit
The list of members of an IRC channel is not sorted alphabetically, see attached screenshot.
Are there additional steps to reproduce? The lists I see in my Thunderbird are sorted correctly.
Unfortunately not. I played with quitting and rejoining and later found the result shown in the screenshot.
I found a way to reproduce: this happens when clicking on the "Conversations" line (the very first item in the list of the left pane) and then selecting a chat room again.
Gonna see if I can help Florian out by grabbing this one.
Alright, I think I've figured this one out - the pane's contacts are being sorted via insertion sort in imconversation.xml in addNick.
addNick relies on the listbox "nicklist" having a reliable count.
At the time of switching from the "Conversation" line in the left pane, the nicklist is hidden, and so we're unable to get a proper count (since apparently listbox will only give us a proper count when the item is visible).
So we simply need to make the contextPane visible before we list the participants. Patch is up next.
Created attachment 642745 [details] [diff] [review]
(In reply to Mike Conley (:mconley) from comment #6)
> Created attachment 642745 [details] [diff] [review]
> Patch v1
What about just moving this line http://hg.mozilla.org/comm-central/annotate/f71ece130895/mail/components/im/content/chat-messenger-overlay.js#l592 to line 496?
Created attachment 643030 [details] [diff] [review]
As suggested here and in IRC, I've moved the code that makes the contextPane visible from the bottom of the function to closer to the top.
Comment on attachment 643030 [details] [diff] [review]
Looks good, thanks! Note: I haven't tested this patch, I assume you have or will before the check-in.
(In reply to Florian Quèze from comment #9)
> Comment on attachment 643030 [details] [diff] [review]
> Patch v2
> Looks good, thanks! Note: I haven't tested this patch, I assume you have or
> will before the check-in.
Yes, manually tested.