The default bug view has changed. See this FAQ.

Filelink offer reappears after converting a large file back to a regular attachment

RESOLVED FIXED in Thunderbird 14.0

Status

Thunderbird
Message Compose Window
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

Trunk
Thunderbird 14.0
x86
All
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird13 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

STR:

1)  Attach a large file in a compose window, causing the Filelink offer to appear
2)  Convert the file to a Filelink
3)  Convert the file back to a regular attachment

What happens?

The Filelink offer reappears.

What's expected?

Since I already know about Filelink, already used it, and decided not to, I really shouldn't hear about it again.
Depends on: 742745
Depends on: 738299
No longer depends on: 742745
Created attachment 612628 [details] [diff] [review]
Patch v1

It looks like we were calling the attachmentsAdded function inside attachmentsConverted.

Fixes that, cleans bigFileObserver.js a little bit, and adds a test.

-Mike
Assignee: nobody → mconley
Attachment #612628 - Flags: review?(squibblyflabbetydoo)
squib:

Just a note that the patch for bug 738299 needs to be applied before this one.

-Mike

Comment 3

5 years ago
Comment on attachment 612628 [details] [diff] [review]
Patch v1

Review of attachment 612628 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me by inspection. Assuming the tests pass, r=me.

::: mail/test/mozmill/cloudfile/test-cloudfile-notifications.js
@@ +8,5 @@
>  
>  let Cu = Components.utils;
>  let Cc = Components.classes;
>  let Ci = Components.interfaces;
> +let Cr = Components.results;

While we're here, maybe switch these to const? (Not that it really matters, but that's how I usually see these.)
Attachment #612628 - Flags: review?(squibblyflabbetydoo) → review+
Created attachment 615344 [details] [diff] [review]
Patch v2 (carrying over r+ from squib)

Unbitrotting due to 744004 landing.
Attachment #612628 - Attachment is obsolete: true
(In reply to Jim Porter (:squib) from comment #3)
> Comment on attachment 612628 [details] [diff] [review]
> Patch v1
> 
> Review of attachment 612628 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This looks good to me by inspection. Assuming the tests pass, r=me.
> 
> ::: mail/test/mozmill/cloudfile/test-cloudfile-notifications.js
> @@ +8,5 @@
> >  
> >  let Cu = Components.utils;
> >  let Cc = Components.classes;
> >  let Ci = Components.interfaces;
> > +let Cr = Components.results;
> 
> While we're here, maybe switch these to const? (Not that it really matters,
> but that's how I usually see these.)

Funnily enough, it turns out that these are all predefined in the global scope.  I'll excise them.
Created attachment 615345 [details] [diff] [review]
Patch v3 (carrying over r+ from squib)

Removing Cc/Ci/Cu/Cr definitions.
Attachment #615344 - Attachment is obsolete: true
Attachment #615345 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/88c29b17c96d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 14.0

Updated

5 years ago
Attachment #615345 - Flags: approval-comm-aurora? → approval-comm-aurora+
Committed to comm-aurora as http://hg.mozilla.org/releases/comm-aurora/rev/0a45d6df193b
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.