Filing bug on these build warnings:
js/src/jsinterp.cpp: In function ‘void LeaveWith(JSContext*)’:
js/src/jsinterp.cpp:954:31: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
js/src/jsopcode.cpp: In member function ‘char& js::Sprinter::operator(size_t)’:
js/src/jsopcode.cpp:778:14: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
In both cases, we're just asserting that a value is nonnegative, and in both cases the value is unsigned so the assertion will trivially always pass.
Created attachment 612601 [details] [diff] [review]
In this patch's first chunk, the stackDepth method on WithObject returns uint32, as shown here:
(the method is inherited from NestedScopeObject)
So that's unsigned.
And the second chunk directly deals with a size_t variable, which is unsigned by definition.
FWIW, it looks like patch's first chunk (and the stackDepth() method that it calls) was added in Bug 713311:
and the second chunk (in jsopcode.cpp) was added in Bug 688891:
Comment on attachment 612601 [details] [diff] [review]
lol. To wit, I have the LeaveWith case nixed in a patch in my queue :)
(In reply to Luke Wagner [:luke] from comment #3)
> lol. To wit, I have the LeaveWith case nixed in a patch in my queue :)
Great minds think alike! :)