Closed Bug 742893 Opened 8 years ago Closed 7 years ago

Make xpc_qsValueTo{Uint,Int}64 public

Categories

(Core :: XPConnect, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Details

Attachments

(2 files)

Most cases of the huge switch break to the end of the switch, which just returns true. It's easier to understand if each case returns directly. (Also, related cleanup.)
Attachment #612666 - Flags: review?(bobbyholley+bmo)
Attachment #612667 - Flags: review?(bobbyholley+bmo)
Comment on attachment 612667 [details] [diff] [review]
Part b: XPCConvert::JSData2Native

There's too much going on in this diff. Please split it up or find some way to make it easy to review.
Attachment #612667 - Flags: review?(bobbyholley+bmo)
Attachment #612666 - Flags: review?(bobbyholley+bmo) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Summary: Cleanup XPCConvert::JSData2Native → Make xpc_qsValueTo{Uint,Int}64 public
Target Milestone: --- → mozilla14
You need to log in before you can comment on or make changes to this bug.