743002 - Drawer: message title bar status between native app and drawer

Status: RESOLVED FIXED

(Pancake Graveyard :: Front-end, defect)

Description

[Gordon Brander :gordonb]

Since the toolbar for the drawer will be kept in the iOS app, we need to be able to:

* Send a message to native when switching to **places** pane
* Receive messages from native when it wants to switch to **stacks** pane

Comment 1

[Gordon Brander :gordonb]

We are now sending an event when switching to places view of drawer https://bitbucket.org/mozillapancake/pancake/changeset/f3d8f12ec645.

to: "native"
msg: { type: 'places:view', place_title: '...' }

Comment 2

[Gordon Brander :gordonb]

Removed toolbar from drawer https://bitbucket.org/mozillapancake/pancake/changeset/c461e79161aa

Comment 3

[Gordon Brander :gordonb]

Attachment: button.png

Width matches the width shown in the comp

Comment 4

[Gordon Brander :gordonb]

Attachment: button-active.png

Width matches comp

Comment 5

[Gordon Brander :gordonb]

The mockup app -- views.mustache -- now supports the places:view message, changing the title of the drawer toolbar when stack is changed.

Comment 6

[Gordon Brander :gordonb]

(In reply to Gordon Brander from comment #5)
> The mockup app -- views.mustache -- now supports the places:view message,
> changing the title of the drawer toolbar when stack is changed.

https://bitbucket.org/mozillapancake/pancake/changeset/a3451edf3fa0

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

(In reply to Gordon Brander from comment #1)
> We are now sending an event when switching to places view of drawer
> https://bitbucket.org/mozillapancake/pancake/changeset/f3d8f12ec645.
> 
> to: "native"
> msg: { type: 'places:view', place_title: '...' }

Hey just to be sure, I actualy receive a places:view message containing a stack_title property. Was that intended?

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

What message do I send to the FE when the user clicks the Back button?

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Can you add a little extra space on the right side of the button images so that the text is centered in the 'straight' part of the button?

Comment 10

[Gordon Brander :gordonb]

Added handler for `stacks:view` event in drawer. So now, all you should have to do to get the drawer to display stacks is send a `stacks:view` event to `drawer`.

Comment 11

[Gordon Brander :gordonb]

The button image matches the size shown in the drawer comps. However, the button in the comp says "back". It should say "stacks". I'll add a new one that should be the right size for the word "stacks".

Comment 12

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

The button size is good. The image just needs to be wider with some extra transparent space on the right side. Because iOS centers the button text at the actual image center.

Comment 13

[Gordon Brander :gordonb]

(In reply to Stefan Arentz [:st3fan] from comment #7)
> Hey just to be sure, I actualy receive a places:view message containing a
> stack_title property. Was that intended?

Oops! My bug comment was incorrect. Yes, you're right: you're viewing the places for a stack, so you should get back the stack_title. The code should be correct.

Comment 14

[Gordon Brander :gordonb]

Attachment: Button with space

Comment 15

[Gordon Brander :gordonb]

Attachment: Active button with space

Comment 16

[Gordon Brander :gordonb]

New button images added. Hope that helps!

Comment 17

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Implemented.