Last Comment Bug 743047 - GC: missing barriers on script atoms
: GC: missing barriers on script atoms
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla14
Assigned To: Terrence Cole [:terrence]
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: 673454
  Show dependency treegraph
Reported: 2012-04-05 15:59 PDT by Terrence Cole [:terrence]
Modified: 2012-04-09 10:09 PDT (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v0 (7.94 KB, patch)
2012-04-05 15:59 PDT, Terrence Cole [:terrence]
wmccloskey: review+
Details | Diff | Splinter Review

Description User image Terrence Cole [:terrence] 2012-04-05 15:59:13 PDT
Created attachment 612721 [details] [diff] [review]

These are only inited and read from, but we need to barrier the init correctly in-case any of the atoms reside in the nursery.
Comment 1 User image Bill McCloskey (:billm) 2012-04-05 16:13:25 PDT
Comment on attachment 612721 [details] [diff] [review]

As Luke would say, righteous.

If it's not too much trouble, could you move js_InitAtomMap into the js namespace?
Comment 2 User image Terrence Cole [:terrence] 2012-04-06 11:49:37 PDT
Comment 3 User image Matt Brubeck (:mbrubeck) 2012-04-09 10:09:38 PDT

Note You need to log in before you can comment on or make changes to this bug.