Closed Bug 743064 Opened 12 years ago Closed 12 years ago

Shutdown FramebufferWatcher thread gracefully

Categories

(Firefox OS Graveyard :: General, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
ProductDemo

People

(Reporter: kanru, Assigned: airpingu)

References

Details

Attachments

(1 file, 2 obsolete files)

Currently the watcher thread is always blocking on read and does not shutdown before the program ends.
Does Firefox even shut down cleanly when the watcher thread is live?  I thought part of XPCOM shutdown was waiting for all event loops to empty.
(In reply to Justin Lebar [:jlebar] from comment #1)
> Does Firefox even shut down cleanly when the watcher thread is live?  I
> thought part of XPCOM shutdown was waiting for all event loops to empty.

Thinker told me they will be reported as leaked resource. I need to verify though.
If it's an XPCOM thread it'll be reported.  Otherwise it won't.
Also, we might as well just use a pthread here, and not bother about shutting it down.
I'll take this bug.
Assignee: nobody → clian
Not very sure if it's suitable to use NS_RUNTIMEABORT() here for the sanity check when the pthread is not created successfully. 

Btw, I'm a beginner for review process. Please feel free to point out any possible mistakes that I could have if any. Thank you!
Attachment #618579 - Flags: review?(kchen)
Attachment #618579 - Flags: review?(jones.chris.g)
Uploaded a new patch with the correct patch header info.
Attachment #618579 - Attachment is obsolete: true
Attachment #618579 - Flags: review?(kchen)
Attachment #618579 - Flags: review?(jones.chris.g)
Assign it to the correct reviewers.
Attachment #618589 - Attachment is obsolete: true
Attachment #618591 - Flags: review?(kchen)
Attachment #618591 - Flags: review?(jones.chris.g)
Comment on attachment 618591 [details] [diff] [review]
Shutdown FramebufferWatcher thread gracefully. v2

I wouldn't quite say that this patch is shutting down the thread gracefully, but this works ;).
Attachment #618591 - Flags: review?(jones.chris.g) → review+
http://hg.mozilla.org/mozilla-central/rev/a8c16e7b819b
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → ProductDemo
Attachment #618591 - Flags: review?(kchen)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: