743171 - Object.getOwnPropertyNames(this) is missing "Proxy"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jesse Ruderman]

In the shell,
  Object.getOwnPropertyNames(this)
seems to be missing Proxy.  For comparison, JSON and Math are present.

Comment 1

[Jesse Ruderman]

Also Audio.

Comment 2

[Jesse Ruderman]

A fix for this (or a solid workaround) would help my DOM fuzzer find objects to mess with and functions to call :)

Comment 3

[Jesse Ruderman]

* http://mxr.mozilla.org/mozilla-central/source/dom/base/nsDOMClassInfoClasses.h
** USSDReceivedEvent

* http://mxr.mozilla.org/mozilla-central/source/dom/bindings/Bindings.conf
** PerformanceTiming

* http://mxr.mozilla.org/mozilla-central/source/dom/webidl/WebIDL.mk

* http://mxr.mozilla.org/mozilla-central/source/layout/build/nsLayoutModule.cpp#1283
** Image

Comment 5

[Boris Zbarsky [:bzbarsky]]

I don't understand comment 3.  For one thing, none of those are about the JS engine.

Patch coming up for Proxy.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Fix the global's enumerate hook to correctly enumerate Proxy and WeakMap.

Comment 7

[Jesse Ruderman]

I split off the DOM bits as bug 807222.

Comment 8

[Jason Orendorff [:jorendorff]]

Comment on attachment 676880 [details] [diff] [review]
Fix the global's enumerate hook to correctly enumerate Proxy and WeakMap.

Review of attachment 676880 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_5/extensions/proxy-enumeration.js
@@ +3,5 @@
> +for (var i = 0; i < list.length; ++i) {
> +    if (list[i] == "Proxy") {
> +        found = true;
> +        break;
> +    }

You could say
  var found = list.indexOf("Proxy") != -1;

Comment 9

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b74aba46826f with that change.

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b74aba46826f