Closed Bug 743223 Opened 8 years ago Closed 8 years ago

Undismissed doorhagers appear after loading a page which opens a new doorhanger

Categories

(Firefox for Android :: General, defect)

14 Branch
ARM
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 14
Tracking Status
blocking-fennec1.0 --- +

People

(Reporter: AdrianT, Assigned: Margaret)

Details

Attachments

(3 files)

Attached image Doorhangers screenshot
Fennec/14.0a1 2012-04-06
Device: Motorola Droid 2(Android 2.3)

Steps to reproduce:
1. Load http://sjeng.org/mozilla/geo.html
2. Without dismissing any of the doorhangers tap in the URL bar.
3. Navigate to http://mozqa.com/data/firefox/geolocation/wifi.html.

Expected results:
A geolocation doorhanger is displayed asking for permission to access the location.

Actual results:
The doorhangers from the first website which were not dismissed are displayed along with the new one.
Assignee: nobody → margaret.leibovic
It sounds like we're not getting rid of doorhangers when we should be. Maybe something is going wrong when we're checking the doorhanger persistence/timeout options?
blocking-fennec1.0: --- → ?
When I reproduced this problem, I found an error happening in the call to removeTransientDoorHangers:

04-11 11:13:27.124 14977 14988 E GeckoApp: Exception handling message "Content:LocationChange":
04-11 11:13:27.124 14977 14988 E GeckoApp: java.util.ConcurrentModificationException
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at java.util.HashMap$HashIterator.nextEntry(HashMap.java:796)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at java.util.HashMap$KeyIterator.next(HashMap.java:823)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.Tab.removeTransientDoorHangers(Tab.java:460)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.GeckoApp.handleLocationChange(GeckoApp.java:673)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.GeckoApp.handleMessage(GeckoApp.java:867)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.handleGeckoMessage(GeckoAppShell.java:1753)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.nativeRun(Native Method)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.GeckoAppShell.runGecko(GeckoAppShell.java:464)
04-11 11:13:27.124 14977 14988 E GeckoApp: 	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:106)
Attached patch patchSplinter Review
Duh, of course the uploaded logs also include this exception :) Thanks for the report!
Attachment #614086 - Flags: review?(mark.finkle)
Attachment #614086 - Flags: review?(mark.finkle) → review+
blocking-fennec1.0: ? → +
https://hg.mozilla.org/mozilla-central/rev/ec39d423e265
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified fixed on:

Nightly/14.0a1 2012-04-16
Device: HTC Desire
OS: Android 2.2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.