Closed Bug 743280 Opened 8 years ago Closed 8 years ago

Makefile.in update to use 680246 - file batch #2 - cosmetic patch edits moved to a separate bug

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla14

People

(Reporter: joey, Assigned: joey)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #739710 +++
Assignee: nobody → joey
Unrelated logic edits removed from patch for bug 739710 .

Declare local vars to hold common path values and use them to shorten the line length of several target commands.

replace "rm -f" with the standard make macro $(RM).

Decorate if conditionals with #{ & }# so editors can display block context.  Continue the trend started by ipc/ makefiles.
Attachment #613339 - Flags: review?(ted.mielczarek)
Comment on attachment 613339 [details] [diff] [review]
cosmetic patch edits removed from bug 739710 submitted under a new bug.

Review of attachment 613339 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that made both reviews much simpler!
Attachment #613339 - Flags: review?(ted.mielczarek) → review+
Try job: https://tbpl.mozilla.org/?tree=Try&rev=41b9b90e7202

win32 failure unrelated, win opt passed

Command ['ssh', '-o', 'IdentityFile=~/.ssh/trybld_dsa', 'trybld@stage.mozilla.org', 'mktemp -d'] returned non-zero exit code: 255
make.exe[1]: Leaving directory `/e/builds/moz2_slave/try-w32-dbg/build/obj-firefox/browser/installer'
Permission denied (publickey).
make.exe[1]: *** [upload] Error 2
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ab1b9cb101
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla14
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/c2ab1b9cb101
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Depends on: 750303
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.