Makefile.in update to use 680246 - file batch #2 - cosmetic patch edits moved to a separate bug

RESOLVED FIXED in mozilla14

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: joey, Assigned: joey)

Tracking

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
+++ This bug was initially created as a clone of Bug #739710 +++
(Assignee)

Updated

5 years ago
Assignee: nobody → joey
(Assignee)

Comment 1

5 years ago
Created attachment 613339 [details] [diff] [review]
cosmetic patch edits removed from bug 739710 submitted under a new bug.

Unrelated logic edits removed from patch for bug 739710 .

Declare local vars to hold common path values and use them to shorten the line length of several target commands.

replace "rm -f" with the standard make macro $(RM).

Decorate if conditionals with #{ & }# so editors can display block context.  Continue the trend started by ipc/ makefiles.
Attachment #613339 - Flags: review?(ted.mielczarek)
Comment on attachment 613339 [details] [diff] [review]
cosmetic patch edits removed from bug 739710 submitted under a new bug.

Review of attachment 613339 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that made both reviews much simpler!
Attachment #613339 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 3

5 years ago
Try job: https://tbpl.mozilla.org/?tree=Try&rev=41b9b90e7202

win32 failure unrelated, win opt passed

Command ['ssh', '-o', 'IdentityFile=~/.ssh/trybld_dsa', 'trybld@stage.mozilla.org', 'mktemp -d'] returned non-zero exit code: 255
make.exe[1]: Leaving directory `/e/builds/moz2_slave/try-w32-dbg/build/obj-firefox/browser/installer'
Permission denied (publickey).
make.exe[1]: *** [upload] Error 2
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ab1b9cb101
Status: NEW → ASSIGNED
Keywords: checkin-needed
Target Milestone: --- → mozilla14
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/c2ab1b9cb101
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Depends on: 750303
You need to log in before you can comment on or make changes to this bug.