Last Comment Bug 743280 - Makefile.in update to use 680246 - file batch #2 - cosmetic patch edits moved to a separate bug
: Makefile.in update to use 680246 - file batch #2 - cosmetic patch edits moved...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Joey Armstrong [:joey]
:
:
Mentors:
Depends on: 680246 734121 739710 750303
Blocks: 734139
  Show dependency treegraph
 
Reported: 2012-04-06 10:48 PDT by Joey Armstrong [:joey]
Modified: 2012-04-30 08:58 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
cosmetic patch edits removed from bug 739710 submitted under a new bug. (14.97 KB, patch)
2012-04-09 10:42 PDT, Joey Armstrong [:joey]
ted: review+
Details | Diff | Splinter Review

Description Joey Armstrong [:joey] 2012-04-06 10:48:10 PDT
+++ This bug was initially created as a clone of Bug #739710 +++
Comment 1 Joey Armstrong [:joey] 2012-04-09 10:42:56 PDT
Created attachment 613339 [details] [diff] [review]
cosmetic patch edits removed from bug 739710 submitted under a new bug.

Unrelated logic edits removed from patch for bug 739710 .

Declare local vars to hold common path values and use them to shorten the line length of several target commands.

replace "rm -f" with the standard make macro $(RM).

Decorate if conditionals with #{ & }# so editors can display block context.  Continue the trend started by ipc/ makefiles.
Comment 2 Ted Mielczarek [:ted.mielczarek] 2012-04-09 11:37:11 PDT
Comment on attachment 613339 [details] [diff] [review]
cosmetic patch edits removed from bug 739710 submitted under a new bug.

Review of attachment 613339 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that made both reviews much simpler!
Comment 3 Joey Armstrong [:joey] 2012-04-09 11:58:17 PDT
Try job: https://tbpl.mozilla.org/?tree=Try&rev=41b9b90e7202

win32 failure unrelated, win opt passed

Command ['ssh', '-o', 'IdentityFile=~/.ssh/trybld_dsa', 'trybld@stage.mozilla.org', 'mktemp -d'] returned non-zero exit code: 255
make.exe[1]: Leaving directory `/e/builds/moz2_slave/try-w32-dbg/build/obj-firefox/browser/installer'
Permission denied (publickey).
make.exe[1]: *** [upload] Error 2
Comment 4 Daniel Holbert [:dholbert] 2012-04-10 10:47:19 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2ab1b9cb101
Comment 5 Matt Brubeck (:mbrubeck) 2012-04-11 09:05:02 PDT
https://hg.mozilla.org/mozilla-central/rev/c2ab1b9cb101

Note You need to log in before you can comment on or make changes to this bug.