Closed Bug 743413 Opened 8 years ago Closed 8 years ago

Move some misc Utils functions into common

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: gps, Assigned: gps)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch Move some codeSplinter Review
Need to move some misc Utils functions into common to support a 200KB patch I'm working on.
Attachment #613053 - Flags: review?(rnewman)
Comment on attachment 613053 [details] [diff] [review]
Move some code

Review of attachment 613053 [details] [diff] [review]:
-----------------------------------------------------------------

::: services/common/utils.js
@@ +126,5 @@
> +  encodeUTF8: function encodeUTF8(str) {
> +    try {
> +      str = this._utf8Converter.ConvertFromUnicode(str);
> +      return str + this._utf8Converter.Finish();
> +    } catch(ex) {

Nit: space.

@@ +135,5 @@
> +  decodeUTF8: function decodeUTF8(str) {
> +    try {
> +      str = this._utf8Converter.ConvertToUnicode(str);
> +      return str + this._utf8Converter.Finish();
> +    } catch(ex) {

Nit: space.
Attachment #613053 - Flags: review?(rnewman) → review+
https://hg.mozilla.org/services/services-central/rev/b2cb9c43964e
Status: NEW → ASSIGNED
Whiteboard: [fixed in services]
Blocks: 727210
Whiteboard: [fixed in services] → [fixed in services][qa-]
https://hg.mozilla.org/mozilla-central/rev/b2cb9c43964e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in services][qa-] → [qa-]
Target Milestone: --- → mozilla14
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.