The default bug view has changed. See this FAQ.

make package fails on platforms where profiler is not available

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Installer
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: gaston, Assigned: gaston)

Tracking

({regression})

Trunk
Firefox 14
All
OpenBSD
regression
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Since landing of #713132, make package fails on OpenBSD (and probably all other platforms where the profiler is not enabled). Patch in a second.
(Assignee)

Updated

5 years ago
Blocks: 713132
(Assignee)

Comment 1

5 years ago
Created attachment 613076 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set
Assignee: nobody → landry
Attachment #613076 - Flags: review?(sgautherie.bz)
(Assignee)

Updated

5 years ago
Keywords: regression

Updated

5 years ago
Component: Build Config → Installer
QA Contact: build.config → installer
Blocks: 699918
Flags: in-testsuite-
Version: unspecified → Trunk
No longer blocks: 699918
Blocks: 734335
Comment on attachment 613076 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

I assume that should be it.
Attachment #613076 - Flags: review?(sgautherie.bz)
Attachment #613076 - Flags: review?(mh+mozilla)
Attachment #613076 - Flags: feedback+
Comment on attachment 613076 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

Review of attachment 613076 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but please patch b2g/installer/package-manifest.in and mobile/android/installer/package-manifest.in, too.
Attachment #613076 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 4

5 years ago
Created attachment 613244 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

Sure, setting checkin-needed for that patch fixing the 3 files
Attachment #613076 - Attachment is obsolete: true
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Looks like this already landed without any notes in this bug.
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdd4141ec53b
Keywords: checkin-needed
Target Milestone: --- → Firefox 14
(In reply to Ryan VanderMeulen from comment #5)
> Looks like this already landed without any notes in this bug.
> http://hg.mozilla.org/integration/mozilla-inbound/rev/cdd4141ec53b

Yes, sorry. I was going to note it, but lost track...
https://hg.mozilla.org/mozilla-central/rev/cdd4141ec53b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Blocks: 744026
You need to log in before you can comment on or make changes to this bug.