743428 - make package fails on platforms where profiler is not available

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Landry Breuil (:gaston)]

Since landing of #713132, make package fails on OpenBSD (and probably all other platforms where the profiler is not enabled). Patch in a second.

Comment 1

[Landry Breuil (:gaston)]

Attachment: package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

Comment 2

[Serge Gautherie (:sgautherie)]

Comment on attachment 613076 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

I assume that should be it.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 613076 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

Review of attachment 613076 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but please patch b2g/installer/package-manifest.in and mobile/android/installer/package-manifest.in, too.

Comment 4

[Landry Breuil (:gaston)]

Attachment: package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

Sure, setting checkin-needed for that patch fixing the 3 files

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Looks like this already landed without any notes in this bug.
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdd4141ec53b

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to Ryan VanderMeulen from comment #5)
> Looks like this already landed without any notes in this bug.
> http://hg.mozilla.org/integration/mozilla-inbound/rev/cdd4141ec53b

Yes, sorry. I was going to note it, but lost track...

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/cdd4141ec53b