Closed Bug 743428 Opened 8 years ago Closed 8 years ago

make package fails on platforms where profiler is not available

Categories

(Firefox :: Installer, defect)

All
OpenBSD
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 14

People

(Reporter: gaston, Assigned: gaston)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

Since landing of #713132, make package fails on OpenBSD (and probably all other platforms where the profiler is not enabled). Patch in a second.
Blocks: 713132
Assignee: nobody → landry
Attachment #613076 - Flags: review?(sgautherie.bz)
Keywords: regression
Component: Build Config → Installer
QA Contact: build.config → installer
Blocks: 699918
Flags: in-testsuite-
Version: unspecified → Trunk
No longer blocks: 699918
Comment on attachment 613076 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

I assume that should be it.
Attachment #613076 - Flags: review?(sgautherie.bz)
Attachment #613076 - Flags: review?(mh+mozilla)
Attachment #613076 - Flags: feedback+
Comment on attachment 613076 [details] [diff] [review]
package profiler.xpt only if MOZ_ENABLE_PROFILER_SPS is set

Review of attachment 613076 [details] [diff] [review]:
-----------------------------------------------------------------

r+, but please patch b2g/installer/package-manifest.in and mobile/android/installer/package-manifest.in, too.
Attachment #613076 - Flags: review?(mh+mozilla) → review+
Sure, setting checkin-needed for that patch fixing the 3 files
Attachment #613076 - Attachment is obsolete: true
Keywords: checkin-needed
Looks like this already landed without any notes in this bug.
http://hg.mozilla.org/integration/mozilla-inbound/rev/cdd4141ec53b
Keywords: checkin-needed
Target Milestone: --- → Firefox 14
(In reply to Ryan VanderMeulen from comment #5)
> Looks like this already landed without any notes in this bug.
> http://hg.mozilla.org/integration/mozilla-inbound/rev/cdd4141ec53b

Yes, sorry. I was going to note it, but lost track...
https://hg.mozilla.org/mozilla-central/rev/cdd4141ec53b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.