Last Comment Bug 743560 - Building Firefox on top of xulrunner failed after d36aeec1abe1 in m-c
: Building Firefox on top of xulrunner failed after d36aeec1abe1 in m-c
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla14
Assigned To: Benjamin Smedberg [:bsmedberg]
:
Mentors:
Depends on: 749573 756786
Blocks: 734975
  Show dependency treegraph
 
Reported: 2012-04-08 05:56 PDT by Takanori MATSUURA
Modified: 2012-05-19 08:23 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Pack xpcshell and run-mozilla.sh again. (835 bytes, patch)
2012-04-09 02:35 PDT, Takanori MATSUURA
benjamin: review-
Details | Diff | Review
Package in the SDK, not in the binary, rev. 1 (930 bytes, patch)
2012-04-10 11:38 PDT, Benjamin Smedberg [:bsmedberg]
dtownsend: review+
t.matsuu: feedback+
Details | Diff | Review

Description Takanori MATSUURA 2012-04-08 05:56:57 PDT
Changeset d36aeec1abe1 in m-c (bug 734975) breaks building Firefox on top of xulrunner.

https://hg.mozilla.org/mozilla-central/rev/d36aeec1abe1

run-mozilla.sh and xpcshell commands are referred as $(LIBXUL_DIST)/bin/run-mozilla.sh and $(LIBXUL_DIST)/bin/xpcshell$(BIN_SUFFIX) in some places in m-c respectively.
Comment 2 Dave Townsend [:mossop] 2012-04-08 08:43:41 PDT
Or we could just go back to shipping those files, I didn't think they would be needed in the xulrunner runtime itself which is why I removed them.
Comment 3 Takanori MATSUURA 2012-04-08 09:57:53 PDT
(In reply to Dave Townsend (:Mossop) from comment #2)
> Or we could just go back to shipping those files

It would make me happy.
Can you make a patch?
Comment 4 Takanori MATSUURA 2012-04-09 02:35:43 PDT
Created attachment 613253 [details] [diff] [review]
Pack xpcshell and run-mozilla.sh again.

Backing out NO_PKG_FILES.
Comment 5 Benjamin Smedberg [:bsmedberg] 2012-04-09 07:30:05 PDT
Comment on attachment 613253 [details] [diff] [review]
Pack xpcshell and run-mozilla.sh again.

These files (xpcshell and run-mozilla) should be packaged in the *SDK* but not in the binary package. Is this makefile being used to package both of these?
Comment 6 Takanori MATSUURA 2012-04-09 08:09:59 PDT
xpcshell is installed to dist/bin by js/xpconnect/shell/Makefile.
run-mozilla.sh is installed to dist/bin by build/unix/Makefile.
Comment 7 Benjamin Smedberg [:bsmedberg] 2012-04-09 08:14:28 PDT
Yes, that's not what I'm asking. We are *intentionally* removing these files from the XULRunner binary package, but we should not be removing them from the SDK package. Is this instance of NO_PKG_FILES removing them from the SDK package by accident? If so, can we fix this so that they continue to be properly removed from the non-SDK package?
Comment 8 Takanori MATSUURA 2012-04-09 16:18:03 PDT
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #7)
> Is this instance of NO_PKG_FILES removing them from the SDK
> package by accident?

No.
xpcshell and run-mozilla.sh are installed to dist/bin as mentioned in comment #6. This means they are never installed to dist/sdk/bin and bundled only as a part of binary package.

So I suppose we need to fix here that
1) xpcshell and run-mozilla.sh should be installed to sdk/bin
2) set $(LIBXUL_DIST)/sdk instead of $(LIBXUL_DIST) for files mentioned in comment #1.

Is this right?
Comment 9 Benjamin Smedberg [:bsmedberg] 2012-04-10 11:37:42 PDT
no. there is no such thing as dist/sdk/bin (I think!). Instead the sdk/bin is the same as dist/bin (in general). I'm going to attach a patch which I *think* does the right thing, but I'll need you to test it.
Comment 10 Benjamin Smedberg [:bsmedberg] 2012-04-10 11:38:34 PDT
Created attachment 613696 [details] [diff] [review]
Package in the SDK, not in the binary, rev. 1
Comment 11 Takanori MATSUURA 2012-04-11 16:26:44 PDT
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #10)
> Created attachment 613696 [details] [diff] [review]
> Package in the SDK, not in the binary, rev. 1

Works fine!
Thanks.
Comment 12 Benjamin Smedberg [:bsmedberg] 2012-04-13 10:40:53 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f872c75a08c
Comment 13 Marco Bonardo [::mak] 2012-04-14 06:44:12 PDT
https://hg.mozilla.org/mozilla-central/rev/3f872c75a08c

Note You need to log in before you can comment on or make changes to this bug.