Closed Bug 743633 Opened 8 years ago Closed 8 years ago
Plugin doorhanger appears after opening background tab with invisible Flash plugin
You need to have the "Tap to Play" setting enabled for plugins for this bug. See url testcase, steps to reproduce: - Visit testcase, ignore the plugin doorhanger by tapping outside of it - Long tap on the "Link to this same page" link to open Context menu - Tap on Open Link in New Tab Expected result: - No plugin doorhanger appears Actual result: - Plugin doorhanger appears Tested in yesterday's trunk Fennec Native build on the Samsung Galaxy Nexus.
This is a doorhanger problem. What's happening here is that we're re-showing the notification for the current tab - if you add a link to a page that shows a different type of doorhanger, you should still see the plugin doorhanger re-appear. I made a testcase for that here: http://people.mozilla.com/~mleibovic/test/flashembed_invisible.html This patch stops us from calling updatePopup (the method that decides to show notifications for the current tab) when adding a new doorhanger notification, unless the notification is actually added to the current tab.
Assignee: nobody → margaret.leibovic
Attachment #613700 - Flags: review?(mark.finkle)
blocking final based on Margaret's comment
blocking-fennec1.0: ? → +
Attachment #613700 - Flags: review?(mark.finkle) → review+
What doorhanger tests do we have?
(In reply to Mark Finkle (:mfinkle) from comment #3) > What doorhanger tests do we have? None! I started working on some in bug 732212 a while ago.
Target Milestone: --- → Firefox 14
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Verified fixed in a 2012-04-14 trunk build on the Samsung Galaxy Nexus.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.