743633 - Plugin doorhanger appears after opening background tab with invisible Flash plugin

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

You need to have the "Tap to Play" setting enabled for plugins for this bug.

See url testcase, steps to reproduce:
- Visit testcase, ignore the plugin doorhanger by tapping outside of it
- Long tap on the "Link to this same page" link to open Context menu
- Tap on Open Link in New Tab

Expected result:
- No plugin doorhanger appears

Actual result:
- Plugin doorhanger appears

Tested in yesterday's trunk Fennec Native build on the Samsung Galaxy Nexus.

Comment 1

[:Margaret Leibovic]

Attachment: patch

This is a doorhanger problem. What's happening here is that we're re-showing the notification for the current tab - if you add a link to a page that shows a different type of doorhanger, you should still see the plugin doorhanger re-appear. I made a testcase for that here: http://people.mozilla.com/~mleibovic/test/flashembed_invisible.html

This patch stops us from calling updatePopup (the method that decides to show notifications for the current tab) when adding a new doorhanger notification, unless the notification is actually added to the current tab.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

blocking final based on Margaret's comment

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

What doorhanger tests do we have?

Comment 4

[:Margaret Leibovic]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> What doorhanger tests do we have?

None! I started working on some in bug 732212 a while ago.

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/280a293f6961

Comment 6

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/280a293f6961

Comment 7

[Martijn Wargers (dead)]

Verified fixed in a 2012-04-14 trunk build on the Samsung Galaxy Nexus.