add browserID log in icon to createaccount.cgi

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
we should add the browserID log in icon to createaccount.cgi
(In reply to Byron Jones ‹:glob› from comment #0)
> we should add the browserID log in icon to createaccount.cgi

BrowserID login for BMO requires the user already have a matching BMO account for it to work. So would having a BrowserID login icon on createaccount.cgi make it confusing to the user whether they just need to use the BrowserID login or should we make it clear they still have to create a BMO account regardless? I would thinking not having any reference to BrowserID on the account creation screen would be less confusing and then having it on all of the login forms as we do currently works well. 

Or am I missing your intent for doing this?

dkl
(Assignee)

Comment 2

6 years ago
(In reply to David Lawrence [:dkl] from comment #1)
> BrowserID login for BMO requires the user already have a matching BMO
> account for it to work.

this isn't true; accounts are created if there isn't a matching account.
(Assignee)

Comment 3

6 years ago
Created attachment 613511 [details] [diff] [review]
patch v1

(In reply to Byron Jones ‹:glob› from comment #2)
> this isn't true; accounts are created if there isn't a matching account.

to clarify this is because BrowserID::Login uses Bugzilla::Auth::Verify->create_or_update_user(), which will create the user if it doesn't already exist.

i think this is the right behavior, so this patch adds the icon to our create-account page, as well as setting user_can_create_account to true in the browserid extension.
Assignee: nobody → glob
Status: NEW → ASSIGNED
Attachment #613511 - Flags: review?(dkl)
Comment on attachment 613511 [details] [diff] [review]
patch v1

Review of attachment 613511 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but I would rather see this as a part of the BrowserID extension itself and not embedded in the BMO extension. I have a sample patch illustrating 
how this could work.

dkl
Attachment #613511 - Flags: review?(dkl) → review-
Created attachment 613768 [details] [diff] [review]
Patch to use BrowserID when creating new account (dkl) (v1)
(Assignee)

Comment 6

6 years ago
(In reply to David Lawrence [:dkl] from comment #4)
> Looks good but I would rather see this as a part of the BrowserID extension
> itself and not embedded in the BMO extension.

ok.

> I have a sample patch illustrating how this could work.

heh, no need to bother with doing a sample patch for me :)
(Assignee)

Comment 7

6 years ago
Created attachment 613897 [details] [diff] [review]
patch v2

this uses a hook as suggested.  i named it 'additional_methods' instead of 'end' to mirror the auth/login hook name.
Attachment #613511 - Attachment is obsolete: true
Attachment #613768 - Attachment is obsolete: true
Attachment #613897 - Flags: review?(dkl)
Comment on attachment 613897 [details] [diff] [review]
patch v2

Review of attachment 613897 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. r=dkl
Attachment #613897 - Flags: review?(dkl) → review+
(In reply to Byron Jones ‹:glob› from comment #6)
> > I have a sample patch illustrating how this could work.
> 
> heh, no need to bother with doing a sample patch for me :)

Sometimes I like to do it just to see if what I am thinking is true or not so when it did work, I felt like sharing what I did :)

dkl
(Assignee)

Comment 10

6 years ago
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.0/
modified extensions/BMO/template/en/default/account/create.html.tmpl
modified extensions/BMO/web/styles/create_account.css
modified extensions/BrowserID/lib/Login.pm
added extensions/BrowserID/template/en/default/hook/account/create-additional_methods.html.tmpl
modified template/en/default/account/create.html.tmpl
Committed revision 8132.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bmo/4.2/
modified extensions/BMO/template/en/default/account/create.html.tmpl
modified extensions/BMO/web/styles/create_account.css
modified extensions/BrowserID/lib/Login.pm
added extensions/BrowserID/template/en/default/hook/account/create-additional_methods.html.tmpl
modified template/en/default/account/create.html.tmpl
Committed revision 8120.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/extensions/browserid/trunk/
modified lib/Login.pm
added template/en/default/hook/account/create-additional_methods.html.tmpl
Committed revision 11.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.