743709 - Edit Profile link is too hard to find

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Aakash Desai [:aakashd]]

The edit profile link is only visible in the profile page. Since there's so much more meta data that can be added, it should be easier to find.

Comment 1

[Aakash Desai [:aakashd]]

r? https://github.com/mozilla/mozillians/pull/208

Comment 2

[Aakash Desai [:aakashd]]

Forget about that last pull request. Here's the real one: 

https://github.com/mozilla/mozillians/pull/209

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/6e5e41d676cfe3facfe2717dc97ea28fec93efe5
Clean up nav bar and uplevel Edit Profile button. bug 743709

https://github.com/mozilla/mozillians/commit/3b33cc5a08523197e0005df5d7d3ea59423fcffb
Merge pull request #209 from sammybahamas/master

Clean up nav bar and uplevel Edit Profile button. bug 743709

Comment 4

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage and dev - account holders can edit their account via the menu drop down.

Comment 5

[Owen Coutts [:tallOwen]]

This doesn't work for users without usernames

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/d3bc0e358d5bd49b470d3c0ab82bd8a99abe1588
Bad username logic in base template. Fix bug743709

https://github.com/mozilla/mozillians/commit/1eb19f36ec5c139673cfb4a75c98e302c58bf219
Merge pull request #215 from tallowen/username-dropdown

Bad username logic in base template. Fix bug743709

Comment 7

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened - username not set

I'm not sure if this was intended - when a username is not set by the account holder the generated-hash is displayed in the upper right-hand corner.

Comment 8

[Matt Brandt [:mbrandt]]

Thanks owen - I hadn't realized your latest tweak was only on dev, sorry for reopening the bug. Bumping to QA verified on dev - when a username contains a u/<hash> the string is replaced  with 'Options.'

https://github.com/mozilla/mozillians/commit/d3bc0e358d5bd49b470d3c0ab82bd8a99abe1588#L0R66