Closed
Bug 743715
Opened 12 years ago
Closed 12 years ago
Cannot build Fennec without jemalloc
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 14
People
(Reporter: gcp, Assigned: gcp)
Details
Attachments
(1 file, 1 obsolete file)
1.90 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
/home/morbo/hg/mozilla-central/mozglue/android/nsGeckoUtils.cpp:64: error: undefined reference to '__wrap_malloc' /home/morbo/hg/mozilla-central/mozglue/android/nsGeckoUtils.cpp:72: error: undefined reference to '__wrap_free' collect2: ld returned 1 exit status make[6]: *** [libmozglue.so] Error 1 The code is: #include <jni.h> // Wrap malloc and free to use jemalloc #define malloc __wrap_malloc #define free __wrap_free #include <stdlib.h> I guess it just need a conditional? I'll have a go at it.
Assignee | ||
Comment 1•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=80754f169a60
Assignee: nobody → gpascutto
Attachment #613359 -
Flags: review?(jones.chris.g)
Comment on attachment 613359 [details] [diff] [review] Patch 1. Fix compiling without jemalloc Looks OK to me but glandium should review the mozglue stuff.
Attachment #613359 -
Flags: review?(jones.chris.g) → review?(mh+mozilla)
Comment 3•12 years ago
|
||
Comment on attachment 613359 [details] [diff] [review] Patch 1. Fix compiling without jemalloc Review of attachment 613359 [details] [diff] [review]: ----------------------------------------------------------------- ::: mozglue/android/Makefile.in @@ +93,5 @@ > DEFINES += -DANDROID_ARM_LINKER > endif > endif > > +ifdef WRAP_MALLOC_CFLAGS That macro doesn't exit. ::: mozglue/android/nsGeckoUtils.cpp @@ +40,2 @@ > // Wrap malloc and free to use jemalloc > +#ifdef WRAP_MALLOC Just use MOZ_MEMORY here.
Attachment #613359 -
Flags: review?(mh+mozilla) → review-
Assignee | ||
Comment 4•12 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=b9a0c146c5ce https://tbpl.mozilla.org/?tree=Try&rev=4b15bc1c0741
Attachment #613359 -
Attachment is obsolete: true
Attachment #613922 -
Flags: review?(mh+mozilla)
Updated•12 years ago
|
Attachment #613922 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 5•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fcd261121c3
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/5fcd261121c3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 14
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•