743753 - Always generate WebGL warnings (remove webgl.verbose pref) and other related improvements

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

The reason why WebGL warnings are disabled by default (have to flip webgl.verbose pref) is that the last time I checked (1 year ago), pages generating many WebGL warnings could be considerably slowed down by them. It seemed that the cost of generating a JS warning was very high.

Two factors could eventually allow us to reconsider that:
 - if JS warnings become cheaper to generate (profile it!)
 - if most WebGL pages no longer generate many warnings (the worst offenders were pages relying on arbitrary attrib locations instead of calling {bind,get}AttribLocation.

Comment 1

[Boris Zbarsky [:bzbarsky]]

If you use the nsContentUtils warning APIs, combined with the WarnOnce stuff on nsIDocument, assuming that's desirable here, then you could vastly reduce the number of warnings generated....

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

WarnOnce definitely sounds like something I want here. Thanks!

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

The problem with ReportToConsole is that it wants a localized string. WebGL warnings aren't currently localized and while that might be a good idea, I don't want to block this on that.

Comment 4

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: 1: limit the number of warnings per WebGL context

Do not generate more than N (where N=32 currently) warnings per WebGL context. + informative extra warning when the Nth warning is generated.

Comment 5

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: 2: remove webgl.verbose pref

With patch 1, this pref isn't useful enough anymore to justify its existence.

Comment 6

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: 3: icing on the cake: rename LogMessage to GenerateWarning

This name matches more closely what this does and the 'severity' of these messages.

Comment 7

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: 4: cherry on the icing: fix the case issues in WebGL method names in warnings

Mostly a plain regex change. Some users reported they were puzzled by inconsistent case like TexImage2D vs texImage2D in WebGL warnings.

Comment 8

[Benoit Jacob [:bjacob] (mostly away)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/69423dd75eb6
http://hg.mozilla.org/integration/mozilla-inbound/rev/6ac4c324163e
http://hg.mozilla.org/integration/mozilla-inbound/rev/b0dc5e163739
http://hg.mozilla.org/integration/mozilla-inbound/rev/434efc02a33b

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/69423dd75eb6
https://hg.mozilla.org/mozilla-central/rev/6ac4c324163e
https://hg.mozilla.org/mozilla-central/rev/b0dc5e163739
https://hg.mozilla.org/mozilla-central/rev/434efc02a33b