PluginInstanceParent.cpp triggers 6 instances of "warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]", on 64-bit GCC 4.6.3

RESOLVED FIXED

Status

()

RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
PluginInstanceParent.cpp currently triggers this build-spew from GCC:

../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp: In member function ‘virtual bool mozilla::plugins::PluginInstanceParent::AnswerNPN_SetValue_NPPVpluginWindow(const bool&, NPError*)’:
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp:346:42: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp: In member function ‘virtual bool mozilla::plugins::PluginInstanceParent::AnswerNPN_SetValue_NPPVpluginTransparent(const bool&, NPError*)’:
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp:356:42: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp: In member function ‘virtual bool mozilla::plugins::PluginInstanceParent::AnswerNPN_SetValue_NPPVpluginUsesDOMForCursor(const bool&, NPError*)’:
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp:365:50: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp: In member function ‘virtual bool mozilla::plugins::PluginInstanceParent::AnswerNPN_SetValue_NPPVpluginDrawingModel(const int&, mozilla::plugins::PPluginInstanceParent::OptionalShmem*, mozilla::plugins::PPluginInstanceParent::CrossProcessMutexHandle*, NPError*)’:
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp:405:48: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
../../../../mozilla/dom/plugins/ipc/PluginInstanceParent.cpp:443:46: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]

From a quick glance, it looks like these are all from casting a non-64-bit-value (e.g. a bool) to a void*, for passing into mNPNIface->setvalue

Comment 1

6 years ago
Bug 743573 fixed:
  AnswerNPN_SetValue_NPPVpluginWindow()
  AnswerNPN_SetValue_NPPVpluginTransparent()
  AnswerNPN_SetValue_NPPVpluginUsesDOMForCursor()

Bug 781058 fixed:
  AnswerNPN_SetValue_NPPVpluginDrawingModel(), Line 405

Bug 781545 fixed:
  AnswerNPN_SetValue_NPPVpluginDrawingModel(), Line 443
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.