Closed Bug 743785 Opened 8 years ago Closed 8 years ago

nsNPAPIPlugin.cpp:385:8: warning: unused variable ‘javaIsEnabled’ [-Wunused-variable]

Categories

(Core :: Plug-ins, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

New build warning:

mozilla/dom/plugins/base/nsNPAPIPlugin.cpp: In static member function ‘static bool nsNPAPIPlugin::RunPluginOOP(const nsPluginTag*)’:
mozilla/dom/plugins/base/nsNPAPIPlugin.cpp:385:8: warning: unused variable ‘javaIsEnabled’ [-Wunused-variable]

This variable was just a helper-var passed in as an outparam to prefs->GetBoolPref, and that GetBoolPref call was replaced with Preferences::GetBool (which doesn't need an outparam): http://hg.mozilla.org/mozilla-central/rev/cb3b3070ceff#l4.51

The variable can just go away.
Attachment #613367 - Flags: review? → review?(joshmoz)
Attachment #613367 - Flags: review?(joshmoz) → review+
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/806aeb3cc9ac
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.