Last Comment Bug 743785 - nsNPAPIPlugin.cpp:385:8: warning: unused variable ‘javaIsEnabled’ [-Wunused-variable]
: nsNPAPIPlugin.cpp:385:8: warning: unused variable ‘javaIsEnabled’ [-Wunused-v...
Product: Core
Classification: Components
Component: Plug-ins (show other bugs)
: Trunk
: All All
-- normal (vote)
: mozilla14
Assigned To: Daniel Holbert [:dholbert]
: Benjamin Smedberg [:bsmedberg]
Depends on:
Blocks: buildwarning 668157
  Show dependency treegraph
Reported: 2012-04-09 13:14 PDT by Daniel Holbert [:dholbert]
Modified: 2012-04-10 08:37 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

trivial fix (drop unused var) (968 bytes, patch)
2012-04-09 13:16 PDT, Daniel Holbert [:dholbert]
jaas: review+
Details | Diff | Splinter Review

Description User image Daniel Holbert [:dholbert] 2012-04-09 13:14:12 PDT
New build warning:

mozilla/dom/plugins/base/nsNPAPIPlugin.cpp: In static member function ‘static bool nsNPAPIPlugin::RunPluginOOP(const nsPluginTag*)’:
mozilla/dom/plugins/base/nsNPAPIPlugin.cpp:385:8: warning: unused variable ‘javaIsEnabled’ [-Wunused-variable]

This variable was just a helper-var passed in as an outparam to prefs->GetBoolPref, and that GetBoolPref call was replaced with Preferences::GetBool (which doesn't need an outparam):

The variable can just go away.
Comment 1 User image Daniel Holbert [:dholbert] 2012-04-09 13:16:15 PDT
Created attachment 613367 [details] [diff] [review]
trivial fix (drop unused var)
Comment 2 User image Daniel Holbert [:dholbert] 2012-04-09 13:37:36 PDT

Note You need to log in before you can comment on or make changes to this bug.