nsNPAPIPlugin.cpp:385:8: warning: unused variable ‘javaIsEnabled’ [-Wunused-variable]

RESOLVED FIXED in mozilla14

Status

()

Core
Plug-ins
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla14
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
New build warning:

mozilla/dom/plugins/base/nsNPAPIPlugin.cpp: In static member function ‘static bool nsNPAPIPlugin::RunPluginOOP(const nsPluginTag*)’:
mozilla/dom/plugins/base/nsNPAPIPlugin.cpp:385:8: warning: unused variable ‘javaIsEnabled’ [-Wunused-variable]

This variable was just a helper-var passed in as an outparam to prefs->GetBoolPref, and that GetBoolPref call was replaced with Preferences::GetBool (which doesn't need an outparam): http://hg.mozilla.org/mozilla-central/rev/cb3b3070ceff#l4.51

The variable can just go away.
(Assignee)

Comment 1

5 years ago
Created attachment 613367 [details] [diff] [review]
trivial fix (drop unused var)
Attachment #613367 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #613367 - Flags: review? → review?(joshmoz)

Updated

5 years ago
Attachment #613367 - Flags: review?(joshmoz) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/806aeb3cc9ac
Target Milestone: --- → mozilla14
(Assignee)

Updated

5 years ago
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/806aeb3cc9ac
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.