The default bug view has changed. See this FAQ.

Fix the warnings generated by WebGL activeTexture

RESOLVED FIXED in mozilla14

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bjacob, Assigned: bjacob)

Tracking

unspecified
mozilla14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 613389 [details] [diff] [review]
fix the warning

Current warnings are bogus/misleading.

+ some minor style/code enhancements.
Attachment #613389 - Flags: review?(jgilbert)
Comment on attachment 613389 [details] [diff] [review]
fix the warning

Review of attachment 613389 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContextGL.cpp
@@ +137,5 @@
> +    if (texture < LOCAL_GL_TEXTURE0 ||
> +        texture >= LOCAL_GL_TEXTURE0 + mGLMaxTextureUnits)
> +    {
> +        return ErrorInvalidEnum(
> +          "ActiveTexture: texture unit %d out of range. "

Should be 4-space not 2-space.
Attachment #613389 - Flags: review?(jgilbert) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a59c745c563
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
(Assignee)

Comment 3

5 years ago
fix warning causing error due to WARNINGS_AS_ERRORS:

http://hg.mozilla.org/integration/mozilla-inbound/rev/b1bed3ae0476
https://hg.mozilla.org/mozilla-central/rev/8a59c745c563
https://hg.mozilla.org/mozilla-central/rev/b1bed3ae0476
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.