Closed
Bug 743813
Opened 10 years ago
Closed 10 years ago
Fix the warnings generated by WebGL activeTexture
Categories
(Core :: Canvas: WebGL, defect)
Core
Canvas: WebGL
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: bjacob, Assigned: bjacob)
Details
Attachments
(1 file)
1.22 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
Current warnings are bogus/misleading. + some minor style/code enhancements.
Attachment #613389 -
Flags: review?(jgilbert)
Comment 1•10 years ago
|
||
Comment on attachment 613389 [details] [diff] [review] fix the warning Review of attachment 613389 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/canvas/src/WebGLContextGL.cpp @@ +137,5 @@ > + if (texture < LOCAL_GL_TEXTURE0 || > + texture >= LOCAL_GL_TEXTURE0 + mGLMaxTextureUnits) > + { > + return ErrorInvalidEnum( > + "ActiveTexture: texture unit %d out of range. " Should be 4-space not 2-space.
Attachment #613389 -
Flags: review?(jgilbert) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8a59c745c563
Assignee: nobody → bjacob
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla14
Assignee | ||
Comment 3•10 years ago
|
||
fix warning causing error due to WARNINGS_AS_ERRORS: http://hg.mozilla.org/integration/mozilla-inbound/rev/b1bed3ae0476
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8a59c745c563 https://hg.mozilla.org/mozilla-central/rev/b1bed3ae0476
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•