743813 - Fix the warnings generated by WebGL activeTexture

Status: RESOLVED FIXED

Description

[Benoit Jacob [:bjacob] (mostly away)]

Created attachment 613389 [details] [diff] [review]
fix the warning

Current warnings are bogus/misleading.

+ some minor style/code enhancements.

Comment 1

[Jeff Gilbert [:jgilbert]]

Comment on attachment 613389 [details] [diff] [review]
fix the warning

Review of attachment 613389 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/src/WebGLContextGL.cpp
@@ +137,5 @@
> +    if (texture < LOCAL_GL_TEXTURE0 ||
> +        texture >= LOCAL_GL_TEXTURE0 + mGLMaxTextureUnits)
> +    {
> +        return ErrorInvalidEnum(
> +          "ActiveTexture: texture unit %d out of range. "

Should be 4-space not 2-space.

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a59c745c563

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

fix warning causing error due to WARNINGS_AS_ERRORS:

http://hg.mozilla.org/integration/mozilla-inbound/rev/b1bed3ae0476

Comment 4

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/8a59c745c563
https://hg.mozilla.org/mozilla-central/rev/b1bed3ae0476