743907 - Add cursor mapper support back to libui

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[Michael Wu [:mwu]]

Attachment: Put cursor mapper back

Apparently we need this to support the ICS emulator. The ICS qemu kernel just provides a mouse0 device which gets treated as a cursor/pointer which the current multitouch/singletouch mappers don't support.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 613485 [details] [diff] [review]
Put cursor mapper back

>-        // Mozilla bug 739417
>-        if (!outPointer.touchMajor)
>-            continue;
>-

Why?

rs=me for the rest.

Comment 2

[Michael Wu [:mwu]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> Comment on attachment 613485 [details] [diff] [review]
> Put cursor mapper back
> 
> >-        // Mozilla bug 739417
> >-        if (!outPointer.touchMajor)
> >-            continue;
> >-
> 
> Why?
> 

Good catch. I accidentally clobbered this.

Comment 3

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8e82bc639a0a

Comment 4

[Michael Wu [:mwu]]

Attachment: Remove use of WeakMessageHandler/MessageHandler

Apparently GB headers don't provide WeakMessageHandler or MessageHandler. Just comment them out since apparently we don't need them.

Comment 5

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1de857c43993 pushed to fix red

Comment 6

[Michael Wu [:mwu]]

Attachment: Remove use of Message

Testing this for real this time

Comment 7

[Michael Wu [:mwu]]

Attachment: Remove use of Message, v2

Comment 8

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ef442645a208 for the third patch

Comment 9

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/8e82bc639a0a
https://hg.mozilla.org/mozilla-central/rev/1de857c43993
https://hg.mozilla.org/mozilla-central/rev/ef442645a208

Comment 10

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

These reviews were pretty pointless ... in the future if the patch is trivial enough to land as a bustage fix, please don't request review.  If it's not that trivial, back out and request review.