Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Add cursor mapper support back to libui

RESOLVED FIXED in mozilla14

Status

()

Core
Widget
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mwu, Assigned: mwu)

Tracking

unspecified
mozilla14
All
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Created attachment 613485 [details] [diff] [review]
Put cursor mapper back

Apparently we need this to support the ICS emulator. The ICS qemu kernel just provides a mouse0 device which gets treated as a cursor/pointer which the current multitouch/singletouch mappers don't support.
Attachment #613485 - Flags: review?(jones.chris.g)
Comment on attachment 613485 [details] [diff] [review]
Put cursor mapper back

>-        // Mozilla bug 739417
>-        if (!outPointer.touchMajor)
>-            continue;
>-

Why?

rs=me for the rest.
Attachment #613485 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

5 years ago
(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> Comment on attachment 613485 [details] [diff] [review]
> Put cursor mapper back
> 
> >-        // Mozilla bug 739417
> >-        if (!outPointer.touchMajor)
> >-            continue;
> >-
> 
> Why?
> 

Good catch. I accidentally clobbered this.
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e82bc639a0a
Target Milestone: --- → mozilla14
(Assignee)

Comment 4

5 years ago
Created attachment 613851 [details] [diff] [review]
Remove use of WeakMessageHandler/MessageHandler

Apparently GB headers don't provide WeakMessageHandler or MessageHandler. Just comment them out since apparently we don't need them.
Attachment #613851 - Flags: review?(jones.chris.g)
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/1de857c43993 pushed to fix red
(Assignee)

Comment 6

5 years ago
Created attachment 613861 [details] [diff] [review]
Remove use of Message

Testing this for real this time
Attachment #613861 - Flags: review?(jones.chris.g)
(Assignee)

Comment 7

5 years ago
Created attachment 613864 [details] [diff] [review]
Remove use of Message, v2
Attachment #613861 - Attachment is obsolete: true
Attachment #613861 - Flags: review?(jones.chris.g)
(Assignee)

Comment 8

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef442645a208 for the third patch
(Assignee)

Updated

5 years ago
Attachment #613864 - Flags: review?(jones.chris.g)
https://hg.mozilla.org/mozilla-central/rev/8e82bc639a0a
https://hg.mozilla.org/mozilla-central/rev/1de857c43993
https://hg.mozilla.org/mozilla-central/rev/ef442645a208
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment #613851 - Flags: review?(jones.chris.g) → review+
Attachment #613864 - Flags: review?(jones.chris.g) → review+
These reviews were pretty pointless ... in the future if the patch is trivial enough to land as a bustage fix, please don't request review.  If it's not that trivial, back out and request review.
You need to log in before you can comment on or make changes to this bug.