743919 - [traceback] ValueError: invalid literal for float(): 99.None

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Rob Hudson [:robhudson]]

File "/data/www/addons.mozilla.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/www/addons.mozilla.org/zamboni/vendor/src/django-mobility/mobility/decorators.py", line 23, in wrapper
    return f(request, *args, **kw)

  File "/data/www/addons.mozilla.org/zamboni/vendor/src/django/django/views/decorators/vary.py", line 19, in inner_func
    response = func(*args, **kwargs)

  File "/data/www/addons.mozilla.org/zamboni/apps/search/views.py", line 688, in search
    'versions': version_sidebar(request, query, facets),

  File "/data/www/addons.mozilla.org/zamboni/apps/search/views.py", line 785, in version_sidebar
    for version, floated in zip(versions, map(float, versions)):


Example URL: https://addons.mozilla.org/en-US/firefox/tag/poop?appver=*

Comment 1

[Rob Hudson [:robhudson]]

This diff fixes the issue but breaks a test. I may look at it a bit more later:

diff --git a/apps/search/views.py b/apps/search/views.py
index 2562443..3667a50 100644
--- a/apps/search/views.py
+++ b/apps/search/views.py
@@ -775,7 +775,7 @@ def version_sidebar(request, query, facets):
     vs = [dict_from_int(f['term']) for f in facets['appversions']]
 
     # Insert the filtered app version even if it's not a facet.
-    av_dict = version_dict(appver)
+    av_dict = dict_from_int(version_int(appver))
     if av_dict and av_dict not in vs and av_dict['major']:
         vs.append(av_dict)

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Saw this again here: http://sentry.dmz.phx1.mozilla.com/addons/group/41/

Comment 3

[krupa raj[:krupa]]

This is still happening @ https://addons-dev.allizom.org/en-US/firefox/search/?appver=*&tag=amazon&atype=2&cat=61

sentry: http://sentry.dmz.phx1.mozilla.com/addons-dev/group/2656/

Comment 4

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/05d13fa

Comment 5

[krupa raj[:krupa]]

verified fixed at https://addons-dev.allizom.org/en-US/firefox/search/?appver=*&tag=amazon&atype=2&cat=61