743963 - Utils.js and toolbars.js are using the "assertions" lib without including it

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Maniac Vlad Florin (:vladmaniac)]

mozilla-esr10 tests are failing because utils.js does not import the assertions lib 

http://mozmill-crowd.blargon7.com/#/functional/report/6e80328ea3027063f668a2dd6c368bd2

Error: 
    assertElementVisible([object Proxy],[object Proxy],false)@resource://mozmill/stdlib/securable-module.js -> file:///tmp/tmp55tXAz.mozmill-tests/lib/utils.js:188

failed 	/testAwesomeBar/testGoButton.js 	testGoButton.js::testClickLocationBarAndGo 	

    assert is not defined

failed 	/testAwesomeBar/testSuggestHistoryBookmarks.js 	testSuggestHistoryBookmarks.js::testSuggestHistoryAndBookmarks 	

    assert is not defined

failed 	/testAwesomeBar/testSuggestHistoryBookmarks.js 	testSuggestHistoryBookmarks.js::testStarInAutocomplete 	

Tests affected:
 	/testAwesomeBar/testGoButton.js
 	/testAwesomeBar/testSuggestHistoryBookmarks.js
 	/testAwesomeBar/testCheckItemHighlight.js
 	/testSecurity/testIdentityPopupOpenClose.js

Comment 1

[Maniac Vlad Florin (:vladmaniac)]

Attachment: quick fix v1.0

Quick fix - somehow the "assertions" lib was not imported 
Fixed this by importing the library in the tests, now the assertions module is usable

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Regression from bug 724713. This should not have happened because we have a couple of tests which make use of this method. Alex, just to be sure, have you really run the tests with the patch applied on Firefox 10?

Comment 3

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Henrik Skupin (:whimboo) from comment #2)
> Regression from bug 724713. This should not have happened because we have a
> couple of tests which make use of this method. Alex, just to be sure, have
> you really run the tests with the patch applied on Firefox 10?

Its clear that the patch in bug bug 724713 does not import assertions.js in the toolbars and utils shared modules. I'm sure that the patch was tested but I figure the magic 'hg qrefresh' 
was missed

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on esr10 as:
http://hg.mozilla.org/qa/mozmill-tests/rev/84a9487efbca

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

There are even more instances for a missing include:
http://mozmill-ci.blargon7.com/#/functional/report/6e80328ea3027063f668a2dd6c296fe4

Comment 6

[Maniac Vlad Florin (:vladmaniac)]

(In reply to Henrik Skupin (:whimboo) from comment #5)
> There are even more instances for a missing include:
> http://mozmill-ci.blargon7.com/#/functional/report/
> 6e80328ea3027063f668a2dd6c296fe4

Please compare with the link from URL section in the bug. the results are identical 
My provides a clean testrun now, applying for toolbars and utils module which are being used in those tests.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I see. Alright so lets close it.